8000 R CMD check fails with dev testthat · Issue #19 · Swarchal/platetools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

R CMD check fails with dev testthat #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hadley opened this issue Apr 3, 2019 · 2 comments
Closed

R CMD check fails with dev testthat #19

hadley opened this issue Apr 3, 2019 · 2 comments

Comments

@hadley
Copy link
hadley commented Apr 3, 2019

Because you have

test_that("missing_wells errors when expected",{
     expect_error(missing_wells(full, well = "well", plate = 1))
	 expect_error(missing_wells(full, well = TRUE))
     expect_error(missing_wells(full, well = full$well))
	 expect_error(missing_wells(as.list(full), well = full$well),
	 expect_error(missing_wells(full, well = missing$wel)))
	 expect_error(missing_wells(as.matrix(full), well = full$well))
	 expect_error(missing_wells(fill, well = full$not_valid_col))
})

But I think you want:

test_that("missing_wells errors when expected",{
  expect_error(missing_wells(full, well = "well", plate = 1))
  expect_error(missing_wells(full, well = TRUE))
  expect_error(missing_wells(full, well = full$well))
  expect_error(missing_wells(as.list(full), well = full$well))
  expect_error(missing_wells(full, well = missing$wel))
  expect_error(missing_wells(as.matrix(full), well = full$well))
  expect_error(missing_wells(fill, well = full$not_valid_col))
})
@hadley
Copy link
Author
hadley commented Apr 18, 2019

Can you please submit an update to CRAN soon? I am aiming to submit testthat next week.

@Swarchal
Copy link
Owner

Yes I will try and submit it before Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @Swarchal
0