[BREAKING] Transform module to ESM #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix loading of jsdoc-plugin
c8 relies on V8 coverage which isn't as good as nyc. Empty lines count as covered, which improves coverage percentage depending on the number of empty lines in a file. Also it doesn't detect an uncovered else-path when there is only an if-clause without else. This requires Node.js v16.17.0, which adds support for multiple loaders (@istanbuljs/esm-loader-hook + esmock).
This reverts commit 93f2b26.
|
LGTM |
flovogt
requested changes
Oct 21, 2022
flovogt
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the help of https://github.com/azu/commonjs-to-es-module-codemod
See also https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c