8000 fix: Detect outdated notation for bootstrap attribute log-level by flovogt · Pull Request #603 · SAP/ui5-linter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Detect outdated notation for bootstrap attribute log-level #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

flovogt
Copy link
Member
@flovogt flovogt commented Mar 13, 2025

Fixes #602

@flovogt flovogt requested a review from a team March 13, 2025 08:59
@flovogt
Copy link
Member Author
flovogt commented Mar 13, 2025

@SAP/ui5-foundation Any recommendation if we should add the bootstrap attribute only to one html page and not to every test page?

matz3
matz3 previously approved these changes Mar 17, 2025
Copy link
Member
@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't mind about adding it to every page.

@flovogt flovogt force-pushed the fix-detection-bootstrap-attribute-loglevel branch from 74c560e to 33d8809 Compare March 17, 2025 12:34
@flovogt flovogt force-pushed the fix-detection-bootstrap-attribute-loglevel branch from 33d8809 to e6158f2 Compare March 17, 2025 12:36
@flovogt flovogt requested a review from matz3 March 17, 2025 12:45
@flovogt flovogt merged commit 4fb76f8 into main Mar 17, 2025
19 checks passed
@flovogt flovogt deleted the fix-detection-bootstrap-attribute-loglevel branch March 17, 2025 12:50
@openui5bot openui5bot mentioned this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap attribute "logLevel" should be reported as a warning finding
2 participants
0