8000 Datamining Pipeline: Memory leaks · Issue #125 · SGpp/SGpp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Datamining Pipeline: Memory leaks #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
elfeck opened this issue Jun 14, 2019 · 1 comment
Open

Datamining Pipeline: Memory leaks #125

elfeck opened this issue Jun 14, 2019 · 1 comment
Labels
bug Crashes, freezes, compilation/run-time errors, undesirable behavior, wrong info in help/docs needs confirmation Issues that should be reproduced by another user (not the submitter), default for new issues

Comments

@elfeck
Copy link
Contributor
elfeck commented Jun 14, 2019

While investigating invalid free() occurring in a datamining pipeline example in conjunction with unique_ptr I noticed that all examples leak memory as per valgrind. E.g.

==29540==
==29540== HEAP SUMMARY:
==29540== in use at exit: 3,319,456 bytes in 40 blocks
==29540== total heap usage: 72,737 allocs, 72,697 frees, 41,529,227 bytes allocated
==29540==
==29540== LEAK SUMMARY:
==29540== definitely lost: 1,344 bytes in 25 blocks
==29540== indirectly lost: 1,658,552 bytes in 7 blocks
==29540== possibly lost: 1,657,112 bytes in 4 blocks
==29540== still reachable: 2,448 bytes in 4 blocks
==29540== suppressed: 0 bytes in 0 blocks
==29540== Rerun with --leak-check=full to see details of leaked memory
==29540==
==29540== For counts of detected and suppressed errors, rerun with: -v
==29540== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

I suspect that this is also due to bad handling of unique_ptr and should be looked into.

@krsgpp
@leiterrl leiterrl added bug Crashes, freezes, compilation/run-time errors, undesirable behavior, wrong info in help/docs needs confirmation Issues that should be reproduced by another user (not the submitter), default for new issues labels Jul 29, 2019
@spc90
Copy link
Member
spc90 commented Jun 17, 2021 •
edited
Loading

Some leaks have since been handled and some things are also false positives from valgrind, but I can make a new analysis either before, or after the pipeline gets extracted into its own repo (later this year), to make sure moving forward there are no more leaks in the existing code.

Edit: As a generic fyi/note-to-self -- there is an old branch (DMPipeline_memcheck_fixes) that afair has some fixes that might not have been merged in master in previous Coding Days, so that's a good place to start in the next memory leak analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Crashes, freezes, compilation/run-time errors, undesirable behavior, wrong info in help/docs needs confirmation Issues that should be reproduced by another user (not the submitter), default for new issues
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elfeck @spc90 @leiterrl
0