8000 [Feature]: Ignore Files When Deploying Theme Extension · Issue #5951 · Shopify/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
[Feature]: Ignore Files When Deploying Theme Extension #5951
Open
@sshaw

Description

@sshaw

What area(s) will this request affect?

Extension

What type of change do you want to see?

New feature

Overview

Currently when running shopify app dev or shopify app deploy errors occur when backup (or other) files exist in the extensions directory. For example:

18:12:49 │              graphiql │ GraphiQL server started on port 3457
18:12:49 │ something-amaaaazing │ Bundling theme extension something-amaaaazing...
18:12:50 │ something-amaaaazing │ Error while updating drafts: blocks directory should only contain .liquid files, snippets directory should only contain .liquid files

Motivation

The file it's referring to are Emacs backups: some-file.liquid~. Instead of succeeding but failing (i.e., nothing is deployed even though command acts as if it did —another issue for another day), the command should look to .gitignore, .npmignore, or similar.

One option it to only deploy files checked into git but this is not too developer friendly as one may not want to check in a file but just wants to test it.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0