Abstract global usage and export patch for window #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
a4ca4e8 to
0312e68
Compare
|
/snapit |
|
🫰✨ Thanks @henrytao-me! Your snapshots have been published to npm. Test the snapshots by updating your "@remote-dom/compat": "0.0.0-snapshot-20250324204457",
"@remote-dom/core": "0.0.0-snapshot-20250324204457",
"@remote-dom/polyfill": "0.0.0-snapshot-20250324204457",
"@remote-dom/react": "0.0.0-snapshot-20250324204457" |
9c369a5 to
3996cd1
Compare
|
/snapit |
|
🫰✨ Thanks @henrytao-me! Your snapshots have been published to npm. Test the snapshots by updating your "@remote-dom/compat": "0.0.0-snapshot-20250325161059",
"@remote-dom/core": "0.0.0-snapshot-20250325161059",
"@remote-dom/polyfill": "0.0.0-snapshot-20250325161059",
"@remote-dom/react": "0.0.0-snapshot-20250325161059" |
vividviolet
reviewed
Mar 25, 2025
| @@ -0,0 +1,9 @@ | |||
| --- | |||
| 'example-kitchen-sink': patch | |||
There was a problem hiding this comment.
I think we only need to patch @remote-dom/react
| // We copy their implementation from the existing global scope when it exists, and | ||
| // provide a minimal working implementation otherwise. | ||
| Object.defineProperty(window, 'location', { | ||
| value: location ?? {protocol: 'https:'}, |
There was a problem hiding this comment.
Should this be globalThis.location?
| }); | ||
|
|
||
| Object.defineProperty(window, 'navigator', { | ||
| value: navigator ?? {userAgent: ''}, |
| } | ||
|
|
||
| export {}; | ||
| patch(window); |
There was a problem hiding this comment.
I think we should keep the old implementation unchanged for the polyfill to be safe. We only need to patch location and navigator for window
|
Close as not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/Shopify/temp-project-mover-Archetypically-20250513094629/issues/525