8000 Remove math.MaxUint64 checks and rely on `RenewedTo` instead · Issue #1721 · SiaFoundation/renterd · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove math.MaxUint64 checks and rely on RenewedTo instead #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ChrisSchinnerl opened this issue Dec 5, 2024 · 0 comments
Open

Remove math.MaxUint64 checks and rely on RenewedTo instead #1721

ChrisSchinnerl opened this issue Dec 5, 2024 · 0 comments
Milestone
v3.0.0

Comments

@ChrisSchinnerl
Copy link
Member

Once we remove RHP2 and RHP3 from the codebase, we should remove the MaxUint64 "hack" which updates the revision number to the max for v2 contracts in chainsubscriber.go as well. We should also remove all remaining checks for that sentinel value and instead rely on the RenewedTo of contracts.

That also means, we need to update our chain subscriber code to pick up on any renewals for a contract and update the RenewedTo field accordingly. Usually that's not necessary since we update the database directly after a renewal, but it might be necessary if the renewal succeeded but something prevented us from writing it to the database.
@ChrisSchinnerl ChrisSchinnerl converted this from a draft issue Dec 5, 2024
@ChrisSchinnerl ChrisSchinnerl added this to the v3.0.0 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Sia
Status: Backlog
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@ChrisSchinnerl
0