8000 Invalid results on some non-Intel platforms (e.g. ARM, PowerPC) · Issue #29 · Smithsonian/SuperNOVAS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Invalid results on some non-Intel platforms (e.g. ARM, PowerPC) #29
Closed
@attipaci

Description

@attipaci

It turns out the char type has different signedness on different platforms. While char is signed on Intel x86, it is unsigned on ARM and PowerPC. Since we stored some of the integer coefficients for series calculations as char to save space, it is really bad news for prior releases on platforms like ARM.

The fix is to explicitly declare the relevant coefficient arrays as signed char, or even better as int8_t. Please avoid using the source and releases on non-x86 platforms prior to the fix. I'll note the commit of for the fix below when ready, and will include it in the upcoming 1.0.2 bug fix release.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0