8000 [suggestion] Add reference symbol for embind methods · Issue #126 · Snapchat/djinni · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
[suggestion] Add reference symbol for embind methods #126
Open
@paulocoutinhox

Description

@paulocoutinhox

Hi,

The current bind code is:

EMSCRIPTEN_BINDINGS(nativium_core_application_core) {
    em::class_<::nativium::core::ApplicationCore>("ApplicationCore")
        .smart_ptr<std::shared_ptr<::nativium::core::ApplicationCore>>("ApplicationCore")
        .function("nativeDestroy", &NTVCoreApplicationCore::nativeDestroy)
        .class_function("shared", NTVCoreApplicationCore::shared)
        .function("multiply", NTVCoreApplicationCore::multiply)
        .function("getVersion", NTVCoreApplicationCore::getVersion)
        ;
}

But on documentation, all functions need have the & symbol.

See on documentation:
https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#classes

Can we change to this?

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0