8000 [FEATURE] Ability to pick images from storage for icons. · Issue #47 · TBog/TBLauncher · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

[FEATURE] Ability to pick images from storage for icons. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Invisible3ck opened this issue Oct 15, 2020 · 17 comments
Closed

[FEATURE] Ability to pick images from storage for icons. #47

Invisible3ck opened this issue Oct 15, 2020 · 17 comments
Assignees
@TBog
Labels
feature request New feature or request help wanted Extra attention is needed

Comments

@Invisible3ck
Copy link

No description provided.

@TBog
Copy link
Owner
TBog commented Oct 15, 2020
  1. Please choose a single feature request per issue.
  2. What custom image are you looking to pick? From the gallery?
  3. Background blur is something I can't do if the user is using a LiveWallpaper

@Invisible3ck
Copy link
Author
Invisible3ck commented Oct 15, 2020 •
edited
Loading

Alright, let's go with custom image. Yes, I would like to pick a custom image from my phone's storage via gallery or file explorer. Whichever one is possible please.

@TBog
Copy link
Owner
TBog commented Oct 15, 2020

Choosing an image from storage is tricky. The user should be allowed to crop / resize it and this adds a lot of UI that I'm not comfortable with.
This is not impossible but I'll leave it for later.

@TBog TBog changed the title [FEATURE] Ability to pick custom images for icons and a blurred app drawer. [FEATURE] Ability to pick images from storage for icons. Oct 15, 2020
@TBog TBog added feature request New feature or request help wanted Extra attention is needed labels Oct 15, 2020
@TBog
Copy link
Owner
TBog commented Nov 29, 2020

I added the ability to choose any icon from an icon pack.
Also icon scale, background color and shape are customizable.
@Invisible3ck try it out in release v4.7-dev.1 and tell me if you still think picking from storage is desired.

@Invisible3ck
Copy link
Author

I added the ability to choose any icon from an icon pack.
Also icon scale, background color and shape are customizable.
@Invisible3ck try it out in release v4.7-dev.1 and tell me if you still think picking from storage is desired.

That’s a nice feature set. I still wish to pick a custom image from storage if possible please.

@Invisible3ck
Copy link
Author

@TBog Hi. How is the progress going with this request? Just curious.

@TBog
Copy link
Owner
TBog commented Jul 12, 2021

I'm sorry, I'm not working on this. Feel free to submit a PR.
Right now I'm struggling with switching from ListView to RecycleView and improving the scroll of the list. Sometimes the result list scroll resets when renaming or editing tags.

@victor0d
Copy link

Only a suggestion, that could be much easier to implement: Forcing the user to choose a image that he/she will edit previously according to a predefined size/aspect-ratio/format. If it is not correct, the launcher will refuse to import it (with an error message).

Obviously the user has to be informed previously about the size/aspect-ratio/format required.

@TBog
Copy link
Owner
TBog commented Feb 3, 2022 •
edited
Loading

Forcing the user to choose a image that he/she will edit previously according to a predefined size/aspect-ratio/format.

I for one don't have an application that can do this. How do you expect others to do this?

Context: I'm using a library for the color chooser (https://github.com/ohmae/color-chooser). It's impossible to use this lib without customization to the layout. This adds a lot of time spent when I need to update the version because I need to sync the source code.
I'm hesitant to add another lib for the image manipulation for the same reason. Most probably I'll need to take the source code to be able to customize the theme and layout.

Some lib candidates I found that may be used:

@victor0d
Copy link
victor0d commented Feb 3, 2022 •
edited
Loading
  • Fair enough TBog. You have a point.
    • Some Gallery Apps have support for it. Although it is true that not all of them.
    • I have just tried the two galleries that I have installed in my phone: Simple-Gallery and AOSP-ROM-Gallery, and, the first one will allow me to specify everything, but the second one only aspect ratios.
    • The main reason to suggest this, was having an option to do it, without increasing the load in the code and longer term support.
    • A basic user guide or through forums, could suggest some apps that could help the user to do that job.
  • At the end of the day, I completely agree with you that adding external libraries will increase the building load and issues with dependencies. Better avoid that road.
  • I could add to your list of candidates ImageMagick: https://github.com/cherryleafroad/Android-ImageMagick7
    But I think this one could be an overkill. It could be trimmed down, but that will be extra integration effort (thinking on new releases)

@TBog
Copy link
Owner
TBog commented Feb 7, 2022

feature added with commit 922657a

@TBog TBog self-assigned this Feb 7, 2022
@victor0d
Copy link

What road did you decided to take for this feature ?

@TBog
Copy link
Owner
TBog commented Feb 10, 2022

I chose https://github.com/Dhaval2404/ImagePicker

  • no need to multidex
  • user can think of the interface as a different app and so I don't need to bother changing the theme
  • easiest of the 3 options to call from java (the libs are written in Kotlin)

@victor0d
Copy link

Actually it was the one that looked better of all those that you proposed and anything else that I manage to find.
You are amazing man.

@victor0d
Copy link

This feature is working now (v6.10(32)). Very cool TBog.

Nevertheless, I would like to suggest to extend the option to Tags and Shortcuts. Right now it is only possible with Apps.

@TBog
Copy link
Owner
TBog commented Mar 8, 2022 •
edited
Loading

Nevertheless, I would like to suggest to extend the option to Tags and Shortcuts. Right now it is only possible with Apps.

fixed in 6f65ca2
test build: v6.10-dev.2

@victor0d
Copy link
victor0d commented Mar 9, 2022

Thank you TBog.

@TBog TBog closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TBog TBog

Labels
feature request New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TBog @Invisible3ck @victor0d
0