8000 Date store not synced properly when using a selector · Issue #160 · TanStack/store · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Date store not synced properly when using a selector #160
Open
@eEQK

Description

@eEQK

Describe the bug

given this store:

import { Store } from '@tanstack/react-store';

export const RootState = new Store({
    selectedDay: new Date(),
});

a is refreshed but b is not

export function DatePicker() {
  const a = useStore(RootState);
  const b = useStore(RootState, (s) => s.selectedDay);
  // ...
}

@thazlett16 said on discord:

I'm guessing this has to do with the shallow compare:
https://github.com/TanStack/store/blob/main/packages/react-store/src/index.ts#L34

I know in Redux they generally recommend storing dates in a serializeable format like the string form (RFC 3339, ISO 8601 etc)

Steps to Reproduce the Bug or Issue

example here: https://stackblitz.com/edit/tanstack-store-thn7c7az?file=src%2Findex.tsx

Expected behavior

both a and b should refresh (unless dates are not supposed to be supported)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0