Comparing changes

- Add automated macOS build workflow for VoiceInk - Include whisper.cpp framework building - Support Debug and Release configurations - Add comprehensive cloud build guide - Enable CI/CD for VoiceInk development

- Remove invalid '?tab=readme-ov-file' from Zip package URL - Update both project.pbxproj and Package.resolved - This should resolve the Swift Package Manager dependency error

- Add explicit -sdk macosx to all xcodebuild commands - Add ONLY_ACTIVE_ARCH=YES to build only current architecture - Specify destination platform for dependency resolution - This should prevent unnecessary iOS/visionOS/watchOS builds

- Update framework copy path to match Xcode project expectation - Change from Frameworks/ to Downloads/build-apple/ directory - Update artifact path accordingly

- Move framework to ../Downloads/build-apple/ to match expected path - Add debugging output to verify directory structure - Update artifact path accordingly

- Fix relative path issue in upload-artifact action - Properly navigate to workspace root for framework placement - Copy framework to build directory for artifact collection - Split artifact preparation and upload into separate steps

- Add comprehensive artifact collection for both Debug and Release builds - Search for built VoiceInk.app in Xcode DerivedData directory - Include both the application and framework in artifacts - Add detailed logging to track build output locations

- Fix double resume issues in ScreenCaptureService text extraction - Add safety guards to download progress tracking continuations - Improve task cancellation handling in AIEnhancementService - Fix TaskDelegate multiple callback protection - Add ContinuationSafety utility classes for future async safety - Organize crash logs in .crashes directory with documentation - Update .gitignore to exclude sensitive crash log files Resolves crashes that occurred after dictating with enhancement mode enabled. All async/await continuation usage now has proper double-resume protection.

Comprehensive fix for the critical CheckedContinuation double resume crashes that were occurring in enhancement mode functionality. ## Root Cause Analysis - CheckedContinuation.resume() being called multiple times on same continuation - Race conditions in Vision framework text extraction callbacks - URLSession delegate issues with download progress tracking - Task lifecycle management problems in enhancement mode - Missing timeout protection for long-running async operations ## Key Changes ### Enhanced ContinuationSafety Utility - Added timeout protection with configurable intervals - Implemented location tracking (file/function/line) for debugging - Added comprehensive logging with os.log - Created memory leak detection for unresumed continuations - Built convenience wrapper functions (withSafeContinuation, withSafeThrowingContinuation) - Added global timeout utility (withTimeout) ### ScreenCaptureService Improvements - Replaced manual safety guards with withSafeContinuation(timeout: 30.0) - Ensured Vision framework callbacks execute on main queue - Added background processing for text recognition - Enhanced error handling and logging ### Model Download Manager Enhancements - Added 5-minute timeout for model downloads via withSafeThrowingContinuation - Added 60-second timeout for CoreML model extraction - Improved error propagation and cleanup - Enhanced background processing for file operations ### AIEnhancementService Task Management - Added withTimeout(seconds: 45) for screen capture operations - Implemented multiple Task.isCancelled checks throughout operations - Enhanced task lifecycle management with proper cleanup - Added comprehensive debug logging ### Comprehensive Test Suite - Created ContinuationSafetyTests.swift with 10+ test cases - Added double resume prevention tests - Added timeout functionality tests - Added screen capture stress tests - Added task cancellation tests - Added integration tests for enhancement mode ## Expected Results ✅ Eliminates CheckedContinuation double resume crashes ✅ Enhanced stability during async operations ✅ Better error handling and debugging capabilities ✅ Graceful timeout handling for long operations ✅ Improved task lifecycle management ## Files Modified - VoiceInk/Utilities/ContinuationSafety.swift (enhanced) - VoiceInk/Services/ScreenCaptureService.swift (safe continuations) - VoiceInk/Whisper/WhisperState+ModelManager.swift (safe downloads) - VoiceInk/Services/AIEnhancementService.swift (task management) ## Files Added - VoiceInk/Tests/ContinuationSafetyTests.swift (comprehensive tests) - VoiceInk/CRASH_FIX_IMPLEMENTATION.md (detailed documentation) - VoiceInk/validate_crash_fix.swift (validation script) Fixes the critical crash reported in .crashes/enhancement-mode-crash-2025-05-27/

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on May 27, 2025

Commits on May 28, 2025

This comparison is taking too long to generate.

Uh oh!