Sokar is Able to Modify Autoscaling Group in Dry-Run Mode · Issue #98 · ThomasObenaus/sokar · GitHub

8000 Sokar is Able to Modify Autoscaling Group in Dry-Run Mode · Issue #98 · ThomasObenaus/sokar · GitHub

More Web Proxy on the site http://driver.im/

Sokar is Able to Modify Autoscaling Group in Dry-Run Mode #98

Closed

Closed

Sokar is Able to Modify Autoscaling Group in Dry-Run Mode #98

Assignees

Labels

Regardless of the dry-run parameter value, the watcher can issue draining commands and autoscaling group size reduction:

sokar/scaler/watchScalingObject.go

Line 46 in f1f98ad

if err := s.openScalingTicket(expected, false); err != nil {

Reproduction:

Run sokar with SK_SCA_MODE:"nomad-dc" and SK_DRY_RUN:"1"
Modify autoscaling group to have desired size more than SK_SCALE_OBJECT_MAX
Observe autoscaling group modified by sokar after SK_SCA_WATCHER_INTERVAL time

Is it a desired behavior or is it better not to apply any changes to infrastructure if sokar is in dry-run?

Metadata

Assignees

ThomasObenaus

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

0