8000 Crash when creating new vertices · Issue #1938 · TrenchBroom/TrenchBroom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when creating new vertices #1938

Closed
muk0r opened this issue Dec 30, 2017 · 11 comments
Closed

Crash when creating new vertices #1938

muk0r opened this issue Dec 30, 2017 · 11 comments
Assignees
@kduske
Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems
Milestone
TrenchBroom 2.0.0

Comments

@muk0r
Copy link
muk0r commented Dec 30, 2017

System Information

TrenchBroom V2.0.0-RC5 on Windows 7

Expected Behavior

roguenode

When moving this node, its expected for a new vertice to be created.

Initially I thought TB was showing me edge and face nodes while in vertex mode. Now Im realizing that its the new feature to create vertices.

When I would go to move the new vertice, TB crashed.

Steps to Reproduce

  1. Turn on Vertex mode.
  2. Hover over an edge and try to make a new vertice
  3. Move the new node
  4. Crash

This is what I had done two separate times but havent been able to reproduce since. The only thing I can think of thats changed is I closed open instances of TB RC4. This happened once on a new map and once on a previously saved map.

Crash Info

vertex_mode_crash.zip
vertex_mode_crash_2.zip
@kduske kduske added this to the TrenchBroom 2.0.0 milestone Dec 30, 2017
@kduske kduske added Platform:All Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems labels Dec 30, 2017
@ericwa
Copy link
Collaborator
ericwa commented Dec 31, 2017

I was trying to reproduce this on a debug build, and got the assert(m_faceHandles.selectedHandleCount() == 1); on line 128 of VertexTool::move to fail. m_faceHandles.selectedHandleCount() was 2.

capture

@kduske kduske self-assigned this Dec 31, 2017
@kduske
Copy link
Collaborator
kduske commented Dec 31, 2017

I'm not having any luck in reproducing this.

@kduske
Copy link
Collaborator
< 8000 a class="author Link--primary text-bold css-overflow-wrap-anywhere " show_full_name="false" data-hovercard-type="user" data-hovercard-url="/users/kduske/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/kduske">kduske commented Dec 31, 2017

Pulling the vertex quickly and outside of the TrenchBroom program window seems to help to trigger the crash.

@muk0r
Copy link
Author
muk0r commented Dec 31, 2017

vertex_mode_crash_3.zip

Eric can chime in on this one a little. Happened on stream while he was watching.

If you create a vertice on a face, then swing that new vertice around all sides of the brush, it can result in a crash,

@muk0r
Copy link
Author
muk0r commented Jan 1, 2018

https://clips.twitch.tv/BelovedNastyTeaPipeHype

Heres the clip of it.

@kduske
Copy link
Collaborator
kduske commented Jan 1, 2018

I'm still unable to reproduce any of these problems, sadly.

@kduske kduske removed their assignment Jan 2, 2018
@ericwa
Copy link
Collaborator
ericwa commented Jan 6, 2018

Was trying to reproduce again on Windows with a debug build. I was pulling vertices off the edges of a cube, dragging them around, undoing, and pulling+dragging again.

I got a crash where the findDraggableHandle(inputState); call on VertexToolController.cpp:103 returned an invalid reference. This is in VertexToolController::MoveVertexPart.

capture

@kduske
Copy link
Collaborator
kduske commented Jan 6, 2018

That particular problem is already fixed on the feature branch.

@ericwa
Copy link
Collaborator
ericwa commented Jan 6, 2018

Also, a couple of times I have gotten assertResult(seam.shift(ShiftSeamForWeaving(position))); to fail in Polyhedron<T,FP,VP>::weave.

Here's a video: https://www.dropbox.com/s/ixbzkhi8fp6ljov/2018-01-05%2023-18-30.flv?dl=0
(1st crash is the weave() one, the other 3 are invalid references from findDraggableHandle)

@kduske
Copy link
Collaborator
kduske commented Jan 6, 2018

This only happens on Windows to me. Also there is something going on when you undo after adding a new vertex; sometimes, the vertex remains at its initial position. None of these happen on Mac. This leads me to believe it has something to do with how events are handled. I‘ll look into it tonight.

@kduske kduske self-assigned this Jan 6, 2018
@kduske
Copy link
Collaborator
kduske commented Jan 6, 2018

Now I can't reproduce any problems again. Odd. Memory corruption?

@kduske kduske mentioned this issue Jan 6, 2018
Merged
@kduske kduske closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kduske kduske

Labels
Prio:1 Highest priority: Crash or crippling bugs, features that enable new ways of working Type:Bug Errors and problems
Projects
None yet
Milestone
TrenchBroom 2.0.0
Development

No branches or pull requests
3 participants
@kduske @ericwa @muk0r
0