8000 SETBLOCK is still block changing like 1.12. · Issue #478 · TriggerReactor/TriggerReactor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SETBLOCK is still block changing like 1.12. #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LimuLhw opened this issue Mar 10, 2022 · 1 comment
Open

SETBLOCK is still block changing like 1.12. #478

LimuLhw opened this issue Mar 10, 2022 · 1 comment
Labels
bug Entire or partly plugin is not working as intended. domain:executor/placeholder Related to TR's executor/placeholder things package:bukkit-latest Related to Bukkit latest (1.13~latest) priority:medium

Comments

@LimuLhw
Copy link
LimuLhw commented Mar 10, 2022

Before/읽어주세요

Make sure that you have used /trg debug so that the more detailed error message will show up in the console.
신고전에 /trg debug 명령어를 사용해서 디버그 모드를 켜주세요. 그래야 콘솔창에 더 자세한 정보가 나옵니다.

Describe the bug/버그 증상
Whether SETBLOCK is still working in 1.12 format,
Colored (wool, concrete, etc.) blocks change to the default white color when using #SETBLOCK.
여전히 SETBLOCK이 1.12 형식으로 작동을 하는건지,
색깔 있는 (양털, 콘크리트 등) 블럭으로
#SETBLOCK 사용시 기본값인 하얀색으로 바뀝니다.

Server information/서버 정보
TRG Version : 3.2.x or 3.3.x Latest Build
Server Version : 1.16.5 Paper Latest

Error message/에러 메시지
No Error Log.

Others/그 밖의 정보들
Using part of the my code :
IF (mpZ-getZNB) == 1
ELSE
#SETBLOCK "SANDSTONE", rsX, rsY, rsZ-1
#SETBLOCK "PURPLE_CONCRETE", rsX, rsY, rsZ+1 //PURPLE_CONCRETE just changed to WHITE_CONCRETE
ENDIF
image
image
@Sayakie Sayakie added package:bukkit-latest Related to Bukkit latest (1.13~latest) bug Entire or partly plugin is not working as intended. category:need-reproduce The issue needs reproduce and hasn't been yet. domain:executor/placeholder Related to TR's executor/placeholder things priority:medium and removed category:need-reproduce The issue needs reproduce and hasn't been yet. labels Mar 10, 2022
@Sayakie
Copy link
Member
Sayakie commented Mar 10, 2022

The part of #SETBLOCK Executor determines their behavior by sets "legacy" variable, but modern (>= 1.13) BukkitAPI implementations still have setData method.

TriggerReactor/bukkit/src/main/resources/Executor/SETBLOCK.js

Line 66 in 410e199

var legacy = typeof block.setData === 'function';

We can resolve this issue by following the steps, but as I mentioned before, it seems urgent to refactoring the Executors and Placeholders.

var legacy = false;
try {
  Class.forName('org.bukkit.entity.Phantom');  // Phantom had been added at 1.13
} catch (_) {
  legacy = true;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Entire or partly plugin is not working as intended. domain:executor/placeholder Related to TR's executor/placeholder things package:bukkit-latest Related to Bukkit latest (1.13~latest) priority:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LimuLhw @Sayakie
0