10000 PositionInfo is an overloaded term · Issue #974 · Uniswap/v4-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PositionInfo is an overloaded term #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johnny-emp opened this issue May 13, 2025 · 1 comment
Open

PositionInfo is an overloaded term #974

johnny-emp opened this issue May 13, 2025 · 1 comment
Labels
triage

Comments

@johnny-emp
Copy link
johnny-emp commented May 13, 2025 •
edited
Loading

Component

No response

Describe the suggested feature and problem it solves.

getPositionInfo returns (uint128 liquidity, uint256 feeGrowthInside0LastX128, uint256 feeGrowthInside1LastX128)

https://github.com/Uniswap/v4-core/blob/main/src/libraries/StateLibrary.sol#L230

but in V4-periphery, PositionInfo represents an identifier for the NFT position. I think it would be helpful is there was more distinction between a raw Uniswap Position, and the tokenized ERC721 Position, so when you're interacting with the PoolManager and PositionManager, these concepts are not so difficult to keep track of.

https://github.com/Uniswap/v4-periphery/blob/ad04c9f24a170accf5ea1b2836bbafd514537ca6/src/interfaces/IPositionManager.sol#L67C5-L67C81

Describe the desired implementation.

Some adjustment to the naming convention would be helpful to make it easier to remember this distinction.

Describe alternatives.

No response

Additional context.

No response
@linear Linear
Copy link
linear bot commented May 13, 2025

PROTO-812 PositionInfo is an overloaded term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnny-emp
0