8000 refactor(graphql): Split getFields into countries and nationalities queries by jekabs-karklins · Pull Request #708 · UserOfficeProject/user-office-backend · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Oct 20, 2022. It is now read-only.

refactor(graphql): Split getFields into countries and nationalities queries #708

Merged
merged 8 commits into from
Aug 29, 2022
Merged

refactor(graphql): Split getFields into countries and nationalities queries #708

merged 8 commits into from
Aug 29, 2022

Conversation

jekabs-karklins
Copy link
Contributor
@jekabs-karklins jekabs-karklins commented Aug 10, 2022 •
edited
Loading

Description

This PR splits ambiguous endpoint getFields into nationalities and countries graphQL queries. Not only does it remove unnecessary get in from of query which makes it consistent with other queries, but also splits the endpoint into two separate calls because they are unrelated.

Motivation and Context

This PR aims to make GraphQL endpoints more consistent and more friendly for 3rd party integration

How Has This Been Tested

  • Manual tests
  • E2E tests

Fixes

https://jira.esss.lu.se/browse/SWAP-2729

Changes

This PR removes the old GraphQL endpoint
getFields

Depends on

UserOfficeProject/user-office-frontend#983

@jekabs-karklins jekabs-karklins requested a review from a team as a code owner August 10, 2022 10:08
@jekabs-karklins jekabs-karklins requested review from RasmiaKulan and removed request for a team August 10, 2022 10:08
@jekabs-karklins jekabs-karklins changed the title refactor(graphql): Split getFields into countries and nationalities q… refactor(graphql): Split getFields into countries and nationalities queries Aug 10, 2022
@jekabs-karklins jekabs-karklins added the review: please A request for an ad-hoc review. label Aug 10, 2022
@jekabs-karklins jekabs-karklins mentioned this pull request Aug 10, 2022
Merged
2 tasks
martin-trajanovski
martin-trajanovski approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor
@martin-trajanovski martin-trajanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice change. 🚀 It makes thigs more clear when you query countries or nationalities

@jekabs-karklins jekabs-karklins merged commit 5cb7fd0 into develop Aug 29, 2022
@jekabs-karklins jekabs-karklins deleted the SWAP-2729-refactor-getfields-to-be-consistent-with-other-end branch August 29, 2022 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martin-trajanovski martin-trajanovski martin-trajanovski approved these changes

@TickleThePanda TickleThePanda TickleThePanda approved these changes

@RasmiaKulan RasmiaKulan Awaiting requested review from RasmiaKulan RasmiaKulan is a code owner automatically assigned from UserOfficeProject/stfc-user-programme

Assignees
No one assigned
Labels
refactor review: please A request for an ad-hoc review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
345B @jekabs-karklins @martin-trajanovski @TickleThePanda
0