8000 Search view should use LMP-style partial chooser, not use featured style for homepage featured posts. · Issue #1023 · WPBuddy/largo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Search view should use LMP-style partial chooser, not use featured style for homepage featured posts. #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
benlk opened this issue Dec 15, 2015 · 2 comments
Closed
2 tasks done

Search view should use LMP-style partial chooser, not use featured style for homepage featured posts. #1023

benlk opened this issue Dec 15, 2015 · 2 comments
Assignees
@benlk
Labels
type: feature request
Milestone
0.5.4

Comments

@benlk
Copy link
Collaborator
benlk commented Dec 15, 2015

From AJ-3:
@benlk benlk self-assigned this Dec 15, 2015
@benlk benlk added this to the 0.5.4 milestone Dec 15, 2015
@benlk
Copy link
Collaborator Author
benlk commented Dec 15, 2015

The search filter can't use the LMP filter, because the LMP filter reads from the query and not from the post. But it's otherwise very similar.

LMP won't return the right post here, though, because the search results filter only affects the partials on the initial page load, not the query vars, and the LMP filter doesn't know the post type of the post that is being displayed. It only knows the query. https://github.com/INN/Largo/blob/master/inc/ajax-functions.php#L111-L119

@benlk
Copy link
Collaborator Author
benlk commented Dec 15, 2015

Making the LMP partial chooser aware of the post type should be a separate issue.

@benlk benlk mentioned this issue Dec 15, 2015
Merged
@benlk benlk closed this as completed Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlk benlk

Labels
type: feature request
Projects
None yet
Milestone
0.5.4
Development

No branches or pull requests
1 participant
@benlk
0