8000 Make sticky header display also on the homepage · Issue #1260 · WPBuddy/largo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make sticky header display also on the homepage #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
benlk opened this issue Aug 1, 2016 · 4 comments
Open
3 tasks done

Make sticky header display also on the homepage #1260

benlk opened this issue Aug 1, 2016 · 4 comments
Assignees
@benlk
Labels
priority: normal Must be completed before release of this version of plugin. status: in progress type: feature request

Comments

@benlk
Copy link
Collaborator
benlk commented Aug 1, 2016 •
edited
Loading

That's modifying this block of code: https://github.com/INN/Largo/blob/master/js/navigation.js#L94-L106

Goals:

  • Rename "Enable the sticky navigation for all screen sizes on article pages" to "Enable the sticky navigation for all screen sizes"
  • Sticky nav displays on all internal pages when so enabled
  • The "Hide the main navigation on article pages and display only the sticky navigation on article pages" checkbox still works as labeled

This should be done in the develop branch.
@benlk benlk added priority: normal Must be completed before release of this version of plugin. type: feature request labels Aug 1, 2016
@benlk benlk self-assigned this Aug 1, 2016
@benlk benlk mentioned this issue Aug 2, 2016
Merged
2 tasks
@benlk
Copy link
Collaborator Author
benlk commented Aug 3, 2016
  • After Display sticky header on all pages #1262, the sticky nav appears at the top of the page on initial page load, when it should not appear until farther down the page (after scrolling past the main nav).

@benlk benlk mentioned this issue Aug 4, 2016
Merged
@benlk
Copy link
Collaborator Author
benlk commented Aug 4, 2016

With #1262 and #1266 merged, and no reported bugs, I think this is safe to close.

@benlk benlk closed this as completed Aug 4, 2016
@benlk benlk reopened this Aug 16, 2016
@benlk
Copy link
Collaborator Author
benlk commented Aug 16, 2016

Reopening this because, on the current develop branch, the sticky nav container has a height set on page load, when the sticky nav should not be displaying (and indeed is not displaying).

@benlk benlk mentioned this issue Aug 16, 2016
Merged
@benlk
Copy link
Collaborator Author
benlk commented Aug 16, 2016

No matter the value of Largo.sticky_nav_options.sticky_nav_display, sticky nav displays on the homepage. This is true in current develop branch as of #1269.

@rclations rclations modified the milestone: Backlog Apr 11, 2017
@benlk benlk removed this from the Backlog milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlk benlk

Labels
priority: normal Must be completed before release of this version of plugin. status: in progress type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aschweigert @benlk @rclations
0