8000 If a post has no top term and no category, largo_top_term's fallback displays nothing · Issue #1340 · WPBuddy/largo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
< 8000 div class="application-main " data-commit-hovercards-enabled data-discussion-hovercards-enabled data-issue-and-pr-hovercards-enabled data-project-hovercards-enabled >

If a post has no top term and no category, largo_top_term's fallback displays nothing #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benlk opened this issue Oct 11, 2016 · 3 comments
Closed

If a post has no top term and no category, largo_top_term's fallback displays nothing #1340

benlk opened this issue Oct 11, 2016 · 3 comments
Assignees
@benlk
Labels
priority: low Nice-to-have in a release. type: bug
Milestone
0.5.6 - Homepage ...

Comments

@benlk
Copy link
Collaborator
benlk commented Oct 11, 2016

https://github.com/INN/Largo/blob/09367b17e4d49578dbcc22d9c0829d3668a1e3f5/inc/related-content.php#L332-L336
@benlk benlk added type: bug priority: low Nice-to-have in a release. labels Oct 11, 2016
@aschweigert
Copy link

more specifically, if a post is in the "uncategorized" category we get nothing even if a top term is set (to a tag or something)

@benlk
Copy link
Collaborator Author
benlk commented Oct 11, 2016

So this looks like this check https://github.com/INN/Largo/blob/09367b17e4d49578dbcc22d9c0829d3668a1e3f5/inc/related-content.php#L334

Should instead lead to querying for tags associated with the post, and putting one of those up.

@benlk benlk self-assigned this Oct 11, 2016
@benlk benlk added this to the 0.5.6 - Homepage Layouts milestone Oct 11, 2016
@benlk
Copy link
Collaborator Author
benlk commented Oct 31, 2016

Fixed with #1094

@benlk benlk closed this as completed Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlk benlk

Labels
priority: low Nice-to-have in a release. type: bug
Projects
None yet
Milestone
0.5.6 - Homepage Layouts
Development

No branches or pull requests
2 participants
@aschweigert @benlk
0