8000 "Exit Clean Read" button is hidden by sticky nav · Issue #768 · WPBuddy/largo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

"Exit Clean Read" button is hidden by sticky nav #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benlk opened this issue Jul 1, 2015 · 1 comment
Closed

"Exit Clean Read" button is hidden by sticky nav #768

benlk opened this issue Jul 1, 2015 · 1 comment
Assignees
@benlk
Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Milestone
0.5.1

Comments

@benlk
Copy link
Collaborator
benlk commented Jul 1, 2015

On sites with sticky nav enabled and the "Clean Reading" feature enabled, the sticky nav will cover the fixed-position "Exit Clean reading" button.

Example: http://jjie.org/like-our-veterans-justice-involved-youth-are-survivors-of-war/108940/

screen shot 2015-07-01 at 5 33 37 pm

In this image, the sticky nav's opacity has been set to 0.5

The clean-read button's syntax is

<a class="clean-read-close" href="#">Exit "Clean Read" mode</a>

And its position-related styles are in clean-read.less:

body.clean-read > .clean-read-close {
  position: fixed;
  top: 10px;
  right: 20px;
}
@aschweigert
Copy link

given that the point of this is to focus the reader experience (for sites still using the crufty old layout) we should probably just hide the sticky nav when "clean read" is employed

@aschweigert aschweigert added type: bug priority: normal Must be completed before release of this version of plugin. labels Jul 2, 2015
@aschweigert aschweigert added this to the 0.5.1 milestone Jul 2, 2015
@benlk benlk mentioned this issue Jul 13, 2015
Closed
1 task
@rnagle rnagle closed this as completed Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benlk benlk

Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Milestone
0.5.1
Development

No branches or pull requests
3 participants
@rnagle @aschweigert @benlk
0