-
Notifications
You must be signed in to change notification settings - Fork 40
Block theme: How do I clear my filtered search? #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd tend to echo Kelly that the breadcrumbs work reasonably for this, and the bery visible active state for the particular tab you're in is good indication of context. I also didn't mind having the "All" tab. |
Although we have technically navigated to a new page, I don't think users consciously note the navigation when they click on a category link, especially given how most modern directories are single-page web pages with no post-back. As @ryelle mentions, I agree that reversing filtering by navigating to a new page doesn't feel obvious. Assuming this is where the "all' button was removed, I would suggest we add it back. |
True. Removing the "All" tab came from a conversation about the multiple selection flow where "all options selected" shows the same results as "all options unselected". The single selection demands an option to show everything, and the current demo site has it correctly. Screenshot below. Therefore, and since tabs behave as single selection views, it makes sense to bring back the "All" option. Landing on the page with all items from a breadcrumb link is definitely a tricky interaction. Although the breadcrumb has the link included, its purpose is primarily about site location. Due to the interaction context, the "All" tab should be next to the rest in the first position. |
Okay, I'll bring back the "All" option in the category nav menu 🙂 |
Describe the bug
We no longer have an "all" category. If I click
Featured
, and search, it will search for the keyword inside theFeatured
category. That is expected.How do I search for my keyword amongst all the categories if I have already selected one? Start here for example.
To Reproduce
Steps to reproduce the behavior:
Featured
pricing
The text was updated successfully, but these errors were encountered: