8000 Return a metadata dict/object instead · Issue #6 · X-Raym/wavfile.py · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Return a metadata dict/object instead #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
endolith opened this issue May 3, 2019 · 3 comments
Open

Return a metadata dict/object instead #6

endolith opened this issue May 3, 2019 · 3 comments

Comments

@endolith
Copy link
Contributor
endolith commented May 3, 2019 •
edited
Loading

The read function has a ton of parameters, and all they do is turn on or off different outputs, though the work of reading them is done either way. It would probably be better to output the metadata as a dictionary, with keys like 'cuelabels', etc
@X-Raym
Copy link
Owner
X-Raym commented May 3, 2019

For backward compatibility with the original function, maybe its better to leave it that way.
But indeed it could be replace by a dictionnary with all set to true by default. It has to be made in consoderation of the original project the code has been extracted (see README).
I dont plan to actively develop this ATM cause I dont need it anymore but if valuable pull requests are proposed Ill consider them. :)

@endolith
Copy link
Contributor Author
endolith commented May 3, 2019

By "original", you mean Joseph Ernest's version, right? Not SciPy's? SciPy only returns rate, data, so rate, data, bits, metadata would be good, I think. I'll modify my fork if you're not interested

@X-Raym
Copy link
Owner
X-Raym commented May 3, 2019

@endolith
As far as I remember it isbthe SciPy version moded.
But if you can assure that it is done in the same logic that this original version then feel free to propose your pull requests an Ill merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endolith @X-Raym
0