8000 Build improvements · Issue #1273 · XRPLF/clio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Build improvements #1273
New issue
New issue
Open
Open
Build improvements#1273
Labels
buildBuild or dependencies changesenhancementNew feature or request
Milestone
 
2.7
@kuznetsss

Description

@kuznetsss
kuznetsss
opened on Mar 18, 2024

We could make some improvements in build process:

  • Remove -Wno- and fix code (maybe will have to leave some of them)

    clio/cmake/Settings.cmake

    Lines 10 to 14 in 94706bf

    -Wno-narrowing
    -Wno-deprecated-declarations
    -Wno-dangling-else
    -Wno-unused-but-set-variable
    -Wnon-virtual-dtor

  • Remove -gdwarf-4 and check that build is still working (should be fine)

    clio/unittests/CMakeLists.txt

    Line 137 in 94706bf

    target_compile_options(clio_options INTERFACE -gdwarf-4)

  • Set compilation flags for Release, Debug and RelWithDebInfo build types by adding something like

set(CMAKE_CXX_FLAGS_DEBUG "-g -O0")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-g1 -O3 -DNDEBUG)")
set(CMAKE_CXX_FLAGS_RELEASE "-g0 -O3 -DNDEBUG")

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildBuild or dependencies changesenhancementNew feature or request

    Type

    No type

    Projects

    Clio

    Status

    📋 Backlog

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0