8000 LedgerResult deserialization: Unmapped AccountSetFlag · Issue #514 · XRPLF/xrpl4j · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

LedgerResult deserialization: Unmapped AccountSetFlag #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nkramer44 opened this issue Dec 18, 2023 · 1 comment
Open

LedgerResult deserialization: Unmapped AccountSetFlag #514

nkramer44 opened this issue Dec 18, 2023 · 1 comment
Milestone
LedgerResult Dese...

Comments

@nkramer44
Copy link
Collaborator

rippled does not seem to validate that AccountSet transactions use valid asf flags. We have logic in AccountSet to try to work around this by having a clearFlagRawValue and setFlagRawValue, and trying to normalize those values into clearFlag and setFlag. The normalization logic checks to see if the raw value is a valid AccountSetFlag by determining if it is less than or equal to the maximum AccountSetFlag value. If it is, it sets the typed field to the mapped value. If it is not, it leaves the typed field empty. This works in most cases, but if an AccountSet transaction gets validated with a ClearFlag or SetFlag value of 11, this logic does not work (11 is reserved for hooks). When the flag is 11, the normalization function incorrectly registers the value as a valid AccountSetFlag and calls AccountSetFlag.forValue() which then throws an exception.
@sappenin
Copy link
Collaborator

What should the fix logic be here?

@sappenin sappenin mentioned this issue Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
LedgerResult Deserialization Issues
Development

No branches or pull requests
2 participants
@sappenin @nkramer44
0