8000 OnchainFundsAnnouncer::fundpsbt tries old interface and generates spurious warning · Issue #199 · ZmnSCPxj/clboss · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

OnchainFundsAnnouncer::fundpsbt tries old interface and generates spurious warning #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ksedgwic opened this issue Apr 29, 2024 · 0 comments
Open

OnchainFundsAnnouncer::fundpsbt tries old interface and generates spurious warning #199

ksedgwic opened this issue Apr 29, 2024 · 0 comments

Comments

@ksedgwic
Copy link
Collaborator

Source has the following comment:

		/* On old C-Lightning, "reserve" is a bool.
		 * Try that first.
		 * If we get a parameter error -32602,
		 * try with a number 0.
		 */

Generates the following:

plugin-clboss: Rpc out: fundpsbt {\"satoshi\": \"all\", \"feerate\": \"normal\", \"startweight\": 214, \"minconf\": 3, \"reserve\": false}
plugin-clboss: Rpc in: fundpsbt {\"satoshi\": \"all\", \"feerate\": \"normal\", \"startweight\": 214, \"minconf\": 3, \"reserve\": false} => error {\"code\":-32602,\"message\":\"reserve: should be an integer: invalid token 'false'\"}
plugin-clboss: Rpc out: fundpsbt {\"satoshi\": \"all\", \"feerate\": \"normal\", \"startweight\": 214, \"minconf\": 3, \"reserve\": 0}
plugin-clboss: Rpc in: fundpsbt {\"satoshi\": \"all\", \"feerate\": \"normal\", \"startweight\": 214, \"minconf\": 3, \"reserve\": 0} => {\"psbt\":\"cHNidP8BALACAAAAAwvxNMx8BjgNJGNjvSWLMQ2UUmEp4vaG1/JI6KuMlR3cAQAAAAABAAAAuet9uTmCzXIbfgTRfSL4CosQaAQN417HeivxTQATTLgDAAAAAP3///+yzRHoA9JDUusOqRYAIwp4+if...

The bool version was deprecated in CLN v23.02, we should remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ksedgwic
0