Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 10 commits
- 11 files changed
- 2 contributors
Commits on Feb 22, 2022
Commits on Feb 23, 2022
-
format: fix copy-paste mistake in Options.ModulePath
I used LangVersion as a starting point, and I must have forgot to delete some of the old lines when modifying in-place. Thanks to Rob Findley for spotting this.
Commits on Mar 4, 2022
-
README: tweak setup instructions for Emacs lsp-mode ≥ 8.0.0
The Emacs lsp-mode 8.0.0 release, https://github.com/emacs-lsp/lsp-mode/releases/tag/8.0.0, exposed the gofumpt setting as a custom variable. Updates the installation instructions with the new setting, while keeping the old method for versions below 8.0.0.
Commits on Mar 16, 2022
-
README: stop mentioning govim and vim-go versions
Both Vim plugins added support for gofumpt via gopls well over a year ago. Stop ensuring the user is up to date, because they most likely are.
-
-
README: update version info now that Go 1.18 is out
cmd/gofmt saw no changes since 1.18rc1.
Commits on Mar 18, 2022
-
remove unintentional debug prints
These were introduced when syncing gofumpt with gofmt from Go 1.18rc1. I didn't notice partially because our tests weren't strict enough; fix that as well. While here, gofumpt our own source code.
-
overhaul how we load module info to format Go files
We would call "go mod edit -json" for each Go file we formatted, as each file may be in a different directory, and thus inside a different module. However, the first mistake is that we always ran the command in the directory where gofumpt is run, not the directory containing each Go file. Our tests weren't strict enough to catch this; now octal-literal.txt is, via its run of gofmt before it calls cd. The second mistake, and a pretty embarrassing one, is that since v0.3.0 made gofumpt concurrent, it has been racy in how it writes to globals like langVersion from multiple goroutines. octal-literals.txt now tests for this by adding a nested Go module. Finally, we could also run into open file limits, because spawning a child process and grabbing its output opens files of its own such as named pipes. The added test shows this with a limit of 256 and 10k tiny Go files: --- FAIL: TestWithLowOpenFileLimit (0.30s) ulimit_unix_test.go:82: writing 10000 tiny Go files ulimit_unix_test.go:104: running with 1 paths ulimit_unix_test.go:104: running with 10000 paths ulimit_unix_test.go:112: error: got non-nil error comment: stderr: open /tmp/TestWithLowOpenFileLimit2753748366/001/p003/014.go: too many open files open /tmp/TestWithLowOpenFileLimit2753748366/001/p003/017.go: too many open files open /tmp/TestWithLowOpenFileLimit2753748366/001/p004/000.go: too many open files open /tmp/TestWithLowOpenFileLimit2753748366/001/p004/019.go: too many open files Instead, only call "go mod edit -json" once per directory, and do it in the main thread to reduce its parallelism. Also make it grab fdSem as well, for good measure. This may not be a complete fix, as we're not sure how many files are open by an exec.Command.Output call. However, we are no longer able to reproduce a failure, so leave that as a TODO. Fixes #208.
Commits on Mar 21, 2022
-
bump deps before the upcoming bugfix release
This should help with support for Go 1.18.
-
And start adding links for the major changes, so any interested users can read more into each topic. We also make the release links use the "v" prefix for consistency.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.3.0...v0.3.1