8000 Add new line after sourceMapingUrl · Issue #48 · magento/baler · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content < 7FFF react-partial partial-name="keyboard-shortcuts-dialog" data-ssr="false" data-attempted-ssr="false" data-react-profiling="false" >
Add new line after sourceMapingUrl #48
Open
@boldhedgehog

Description

@boldhedgehog

New line is missing after sourceMappingURL hint causing next merged file be on the same line as the comment:

// some code
gento_Theme/js/theme"]})}(require);
//# sourceMappingURL=requirejs-bundle-config.js.map;try { <==== this is a problem
    if (!window.localStorage || !window.sessionStorage) {
        throw new Error();
    }

    localStorage.setItem('storage_test', 1);
    localStorage.removeItem('storage_test');

Steps to reproduce:

  • Install Baler, Magento Baler module;
  • Fulfil Baler requirements: JS bundling, minification are disabled;
  • Generate static and Baler bundles;
  • Generated requirejs-bundle-config.js and balerbundles/core-bundle.js have no new line in the end
  • Merged JS files are invalid.

core-bundle (copy).zip
requirejs-bundle-config.zip

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0