github: Use Authorization header for authentication #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meling
added a commit
to quickfeed/quickfeed
that referenced
this pull request
Feb 5, 2020
This commit is to try out the fork by mrkschan markbates/goth#314 To see if it solves the depracation issue related to: Please use the Authorization HTTP header instead as using the `access_token` query parameter is deprecated. Command used to install replace directive: go mod edit -replace=github.com/markbates/goth@master=github.com/mrkschan/goth@master Once the PR #314 has been merged, the dropreplace directive should be used: go mod edit -dropreplace=github.com/mrkschan/goth@master
bentranter
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See deprecation notice - https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters
Resolve #311