8000 Migrate from PromiseKit to Swift Concurrency · Issue #564 · mas-cli/mas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate from PromiseKit to Swift Concurrency #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers a 8000 nd the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rgoldberg opened this issue Oct 11, 2024 · 0 comments · Fixed by #737
Closed

Migrate from PromiseKit to Swift Concurrency #564

rgoldberg opened this issue Oct 11, 2024 · 0 comments · Fixed by #737
Assignees
@rgoldberg
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc. 📚 dependencies Update dependencies
Milestone
2.0

Comments

@rgoldberg
Copy link
Contributor
rgoldberg commented Oct 11, 2024 •
edited
Loading

Migrate from PromiseKit to Swift Concurrency.

This would requite macOS 10.15+, while mas currently supports 10.11+.

This would allow us to upgrade Swift to 5.7+ (Swift 5.7+ through current 6 can run on macOS 10.13+; Swift would, however, limit the macOS versions usable for development to newer versions; see https://developer.apple.com/support/xcode/).

What would we gain & what would we lose (besides support for macOS 10.11-10.14) from this switch?

I have a local branch that I've switched to Swift Concurrency, but I won't submit it until we decide to go ahead with this.

It will be out of date by any time we might decide to make this switch, but it will be at least a helpful starting guide.

See apple/swift-argument-parser#662 (comment) for issues with using Concurrency with SAP & newer versions of Swift / Xcode…
@rgoldberg rgoldberg added 🧽 chore Administrative task: documentation, build, test, release, git, etc. 💬 team discussion labels Oct 11, 2024
@rgoldberg rgoldberg changed the title Migrate from PromiseKit to Swift Concurrency. Migrate from PromiseKit to Swift Concurrency Oct 29, 2024
@rgoldberg rgoldberg added the 📚 dependencies Update dependencies label Dec 23, 2024
@rgoldberg rgoldberg self-assigned this Apr 10, 2025
@rgoldberg rgoldberg added this to the 1.9.1 milestone Apr 10, 2025
@rgoldberg rgoldberg mentioned this issue Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgoldberg rgoldberg

Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc. 📚 dependencies Update dependencies
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Use Swift Concurrency instead of PromiseKit rgoldberg/mas
1 participant
@rgoldberg
0