Fix GcmPushkin to handle app ID globs correctly, introduced in 0.5.0
#270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a1f148 to
b1b6c6d
Compare
reivilibre
reviewed
Nov 5, 2021
sygnal/gcmpushkin.py
Outdated
| # `Notification` with a matching app ID. We do something a little dirty and | ||
| # perform all of our dispatches the first time we get called for a | ||
| # `Notification` and do nothing for the rest of the times we get called. | ||
| app_id_pattern = glob_to_regex(self.name, ignore_case=False) |
There was a problem hiding this comment.
Please can you pre-compile this at startup? re.compile is was(?)* expensive.
*I believe it used to bypass the cache. Looking at the code in my Python 3.9 install, it seems like it uses the cache now.
However, pre-compiling is probably still best practice, especially since it's trivial to do in this case.
There was a problem hiding this comment.
I've changed it to be explicitly cached on startup.
reivilibre
previously approved these changes
Nov 8, 2021
It'll be because it needs #268 to be merged first. |
|
Nothing's really changed since the last review. It's only a merge from main followed by a switch to |
reivilibre
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #255 together with
#268#281 and #269.