8000 "default_payload was misconfigured, this value must be a dict" error is noisy · Issue #314 · matrix-org/sygnal · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

"default_payload was misconfigured, this value must be a dict" error is noisy #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anoadragon453 opened this issue Jul 18, 2022 · 0 comments · Fixed by #315
Closed

"default_payload was misconfigured, this value must be a dict" error is noisy #314

anoadragon453 opened this issue Jul 18, 2022 · 0 comments · Fixed by #315
Labels
enhancement

Comments

@anoadragon453
Copy link
Member

Describe the bug
As of #292 we now check that default_payload is a dictionary before interacting with it. default_payload is a user-supplied dictionary which is set when a client sets up their pusher via POST /_matrix/client/v3/pushers/set.

While we now successfully catch when clients set this value incorrectly, raising an error means that this we get notified via Sentry when it happens - and as this data is user-supplied, we can't really do much about it, making the error noise.

This issue proposes to downgrade the log from an error to a warning. Such instances will then still be logged, but not show up in Sentry/potentially alarm sysadmins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't attempt delivery of notification if we have rejected pushkey matrix-org/sygnal
1 participant
@anoadragon453
0