You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{"payload":{"commitGroups":[{"title":"Nov 30, 2020","commits":[{"oid":"d4eaff6b84292ca0231505c4aba8cc6b55df79e3","url":"/mbgg/kexec-tools/commit/d4eaff6b84292ca0231505c4aba8cc6b55df79e3","authoredDate":"2020-11-30T14:41:25.000+08:00","committedDate":"2020-11-30T17:35:36.000+01:00","shortMessage":"zlib: fix resource leak when gzdirect failed","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"zlib: fix resource leak when gzdirect failed\n\nIn function zlib_decompress_file, when gzdirect(fp) fails,\nwe should gzclose fp before return.\n\nFixes: d606837b56d46 (\u0026quot;Fix zlib/lzma decompression.\u0026quot;)\nSigned-off-by: qiuguorui1 \u0026lt;qiuguorui1@huawei.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/d4eaff6b84292ca0231505c4aba8cc6b55df79e3\"\u003ezlib: fix resource leak when gzdirect failed\u003c/a\u003e","bodyMessageHtml":"In function zlib_decompress_file, when gzdirect(fp) fails,\nwe should gzclose fp before return.\n\nFixes: \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/mbgg/kexec-tools/commit/d606837b56d46eb7f815b5d85f07fcc3f1555d00/hovercard\" href=\"https://github.com/mbgg/kexec-tools/commit/d606837b56d46eb7f815b5d85f07fcc3f1555d00\"\u003e\u003ctt\u003ed606837\u003c/tt\u003e\u003c/a\u003e (\"Fix zlib/lzma decompression.\")\nSigned-off-by: qiuguorui1 \u0026lt;qiuguorui1@huawei.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"qiuguorui1","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"4149df9005f2cdd2ecf70058dfe7d72f48c3a68c","url":"/mbgg/kexec-tools/commit/4149df9005f2cdd2ecf70058dfe7d72f48c3a68c","authoredDate":"2020-11-25T23:26:59.000+01:06","committedDate":"2020-11-30T17:33:25.000+01:00","shortMessage":"printk: add support for lockless ringbuffer","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"printk: add support for lockless ringbuffer\n\nLinux 5.10 moved to a new lockless ringbuffer. The new ringbuffer\nis structured completely different to the previous iterations.\nAdd support for retrieving the ringbuffer using vmcoreinfo. The\nnew ringbuffer is detected based on the availability of the\n\u0026quot;prb\u0026quot; symbol.\n\nSigned-off-by: John Ogness \u0026lt;john.ogness@linutronix.de\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/4149df9005f2cdd2ecf70058dfe7d72f48c3a68c\"\u003eprintk: add support for lockless ringbuffer\u003c/a\u003e","bodyMessageHtml":"Linux 5.10 moved to a new lockless ringbuffer. The new ringbuffer\nis structured completely different to the previous iterations.\nAdd support for retrieving the ringbuffer using vmcoreinfo. The\nnew ringbuffer is detected based on the availability of the\n\"prb\" symbol.\n\nSigned-off-by: John Ogness \u0026lt;john.ogness@linutronix.de\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"jogness","displayName":"John Ogness","avatarUrl":"https://avatars.githubusercontent.com/u/12857786?v=4","path":"/jogness","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Nov 16, 2020","commits":[{"oid":"6b5667debcb8ea6d3da88692a6c51049a2c6013d","url":"/mbgg/kexec-tools/commit/6b5667debcb8ea6d3da88692a6c51049a2c6013d","authoredDate":"2020-10-09T17:40:07.000+02:00","committedDate":"2020-11-16T11:59:01.000+01:00","shortMessage":"x86_64: allow ELFCLASS32 for x32 support","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"x86_64: allow ELFCLASS32 for x32 support\n\nSigned-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/6b5667debcb8ea6d3da88692a6c51049a2c6013d\"\u003ex86_64: allow ELFCLASS32 for x32 support\u003c/a\u003e","bodyMessageHtml":"Signed-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"nabijaczleweli","displayName":"Ahelenia Ziemiańska","avatarUrl":"https://avatars.githubusercontent.com/u/6709544?v=4","path":"/nabijaczleweli","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"5c7f47ddc24b92ec2b345660b701c4bf1c0d8032","url":"/mbgg/kexec-tools/commit/5c7f47ddc24b92ec2b345660b701c4bf1c0d8032","authoredDate":"2020-10-09T17:39:58.000+02:00","committedDate":"2020-11-16T11:58:59.000+01:00","shortMessage":"i386: fix string formatting-related warnings","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"i386: fix string formatting-related warnings\n\nfixed the same way as in 70cca82\n\u0026quot;kexec: Fix snprintf related compilation warnings\u0026quot;\n\nSigned-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/5c7f47ddc24b92ec2b345660b701c4bf1c0d8032\"\u003ei386: fix string formatting-related warnings\u003c/a\u003e","bodyMessageHtml":"fixed the same way as in \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/mbgg/kexec-tools/commit/70cca8228435e9cbd88c012f22b9c917a39b1535/hovercard\" href=\"https://github.com/mbgg/kexec-tools/commit/70cca8228435e9cbd88c012f22b9c917a39b1535\"\u003e\u003ctt\u003e70cca82\u003c/tt\u003e\u003c/a\u003e\n\"kexec: Fix snprintf related compilation warnings\"\n\nSigned-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"nabijaczleweli","displayName":"Ahelenia Ziemiańska","avatarUrl":"https://avatars.githubusercontent.com/u/6709544?v=4","path":"/nabijaczleweli","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"3dce5cedbd08d7dcfff5f592b353599b5f0371cb","url":"/mbgg/kexec-tools/commit/3dce5cedbd08d7dcfff5f592b353599b5f0371cb","authoredDate":"2020-10-09T17:39:51.000+02:00","committedDate":"2020-11-16T11:58:58.000+01:00","shortMessage":"i386/kexec-mb2-x86.c: cast ints to uintptr_t before pointers to avoid warnings","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"i386/kexec-mb2-x86.c: cast ints to uintptr_t before pointers to avoid warnings\n\nSigned-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/3dce5cedbd08d7dcfff5f592b353599b5f0371cb\"\u003ei386/kexec-mb2-x86.c: cast ints to uintptr_t before pointers to avoid warnings\u003c/a\u003e","bodyMessageHtml":"Signed-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"nabijaczleweli","displayName":"Ahelenia Ziemiańska","avatarUrl":"https://avatars.githubusercontent.com/u/6709544?v=4","path":"/nabijaczleweli","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"6caad4c497726983864401545aa7a29934ddd67d","url":"/mbgg/kexec-tools/commit/6caad4c497726983864401545aa7a29934ddd67d","authoredDate":"2020-10-09T17:39:42.000+02:00","committedDate":"2020-11-16T11:58:55.000+01:00","shortMessage":"configure.ac, arch/x86_64: handle x32 as subarch of x86_64 and don't specify -mcmodel=large there","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"configure.ac, arch/x86_64: handle x32 as subarch of x86_64 and don\u0026#39;t specify -mcmodel=large there\n\nSigned-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/6caad4c497726983864401545aa7a29934ddd67d\"\u003econfigure.ac, arch/x86_64: handle x32 as subarch of x86_64 and don't specify -mcmodel=large there\u003c/a\u003e","bodyMessageHtml":"Signed-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"nabijaczleweli","displayName":"Ahelenia Ziemiańska","avatarUrl":"https://avatars.githubusercontent.com/u/6709544?v=4","path":"/nabijaczleweli","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"9d33ea597977646fac180f56612be3b2cac7347c","url":"/mbgg/kexec-tools/commit/9d33ea597977646fac180f56612be3b2cac7347c","authoredDate":"2020-10-09T17:39:31.000+02:00","committedDate":"2020-11-16T11:58:51.000+01:00","shortMessage":"config: update to latest config.{sub,guess}, install-sh","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"config: update to latest config.{sub,guess}, install-sh\n\nSigned-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/9d33ea597977646fac180f56612be3b2cac7347c\"\u003econfig: update to latest config.{sub,guess}, install-sh\u003c/a\u003e","bodyMessageHtml":"Signed-off-by: Ahelenia Ziemiańska \u0026lt;nabijaczleweli@nabijaczleweli.xyz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"nabijaczleweli","displayName":"Ahelenia Ziemiańska","avatarUrl":"https://avatars.githubusercontent.com/u/6709544?v=4","path":"/nabijaczleweli","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Oct 23, 2020","commits":[{"oid":"1e9de8e72054d255d6e90304aab38750a82199ee","url":"/mbgg/kexec-tools/commit/1e9de8e72054d255d6e90304aab38750a82199ee","authoredDate":"2020-10-02T15:42:48.000+02:00","committedDate":"2020-10-23T11:42:56.000+02:00","shortMessage":"arm64: Add purgatory printing","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"arm64: Add purgatory printing\n\nAdd option to allow purgatory printing on arm64 hardware\nby passing the console name which should be used.\nBased on a patch by Geoff Levand.\n\nSigned-off-by: Matthias Brugger \u0026lt;mbrugger@suse.com\u0026gt;\nAcked-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/1e9de8e72054d255d6e90304aab38750a82199ee\"\u003earm64: Add purgatory printing\u003c/a\u003e","bodyMessageHtml":"Add option to allow purgatory printing on arm64 hardware\nby passing the console name which should be used.\nBased on a patch by Geoff Levand.\n\nSigned-off-by: Matthias Brugger \u0026lt;mbrugger@suse.com\u0026gt;\nAcked-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"mbgg","displayName":"Matthias Brugger","avatarUrl":"https://avatars.githubusercontent.com/u/259494?v=4","path":"/mbgg","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Sep 29, 2020","commits":[{"oid":"70cca8228435e9cbd88c012f22b9c917a39b1535","url":"/mbgg/kexec-tools/commit/70cca8228435e9cbd88c012f22b9c917a39b1535","authoredDate":"2020-09-23T16:42:37.000+05:30","committedDate":"2020-09-29T18:18:38.000+02:00","shortMessage":"kexec: Fix snprintf related compilation warnings","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec: Fix snprintf related compilation warnings\n\nThis patch fixes the following snprintf related compilation warning\nseen currently with gcc versions 7 and 8 when kexec is compiled with\n-Wformat-truncation option:\n\n kexec/fs2dt.c:673:34: warning: ‘stdout-path’ directive output may be truncated writing 11 bytes into a region of size between 1 and 1024 [-Wformat-truncation=]\n snprintf(filename, MAXPATH, \u0026quot;%sstdout-path\u0026quot;, pathname);\n ^~~~~~~~~~~\n kexec/fs2dt.c:673:3: note: ‘snprintf’ output between 12 and 1035 bytes into a destination of size 1024\n snprintf(filename, MAXPATH, \u0026quot;%sstdout-path\u0026quot;, pathname);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n kexec/fs2dt.c:676:35: warning: ‘linux,stdout-path’ directive output may be truncated writing 17 bytes into a region of size between 1 and 1024 [-Wformat-truncation=]\n snprintf(filename, MAXPATH, \u0026quot;%slinux,stdout-path\u0026quot;, pathname);\n ^~~~~~~~~~~~~~~~~\n kexec/fs2dt.c:676:4: note: ‘snprintf’ output between 18 and 1041 bytes into a destination of size 1024\n snprintf(filename, MAXPATH, \u0026quot;%slinux,stdout-path\u0026quot;, pathname);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n kexec/firmware_memmap.c:132:35: warning: ‘%s’ directive output may be truncated writing 5 bytes into a region of size between 0 and 4095 [-Wformat-truncation=]\n snprintf(filename, PATH_MAX, \u0026quot;%s/%s\u0026quot;, entry, \u0026quot;start\u0026quot;);\n ^~ ~~~~~~~\n kexec/firmware_memmap.c:132:2: note: ‘snprintf’ output between 7 and 4102 bytes into a destination of size 4096\n snprintf(filename, PATH_MAX, \u0026quot;%s/%s\u0026quot;, entry, \u0026quot;start\u0026quot;);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n kexec/firmware_memmap.c:142:35: warning: ‘%s’ directive output may be truncated writing 3 bytes into a region of size between 0 and 4095 [-Wformat-truncation=]\n snprintf(filename, PATH_MAX, \u0026quot;%s/%s\u0026quot;, entry, \u0026quot;end\u0026quot;);\n ^~ ~~~~~\n kexec/firmware_memmap.c:142:2: note: ‘snprintf’ output between 5 and 4100 bytes into a destination of size 4096\n snprintf(filename, PATH_MAX, \u0026quot;%s/%s\u0026quot;, entry, \u0026quot;end\u0026quot;);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n kexec/firmware_memmap.c:152:35: warning: ‘%s’ directive output may be truncated writing 4 bytes into a region of size between 0 and 4095 [-Wformat-truncation=]\n snprintf(filename, PATH_MAX, \u0026quot;%s/%s\u0026quot;, entry, \u0026quot;type\u0026quot;);\n ^~ ~~~~~~\n kexec/firmware_memmap.c:152:2: note: ‘snprintf’ output between 6 and 4101 bytes into a destination of size 4096\n snprintf(filename, PATH_MAX, \u0026quot;%s/%s\u0026quot;, entry, \u0026quot;type\u0026quot;);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSince the simplest method to address the gcc warnings and possible\ntruncation would be to check the return value provided from snprintf\n(well there are other methods like using \u0026#39;asnprintf\u0026#39; or using\n\u0026#39;open_memstream\u0026#39; function to create the FILE object, but these are more\nintrusive), so this patch does the same.\n\nCc: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\nCc: Eric Biederman \u0026lt;ebiederm@xmission.com\u0026gt;\nCc: kexec@lists.infradead.org\nSigned-off-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/70cca8228435e9cbd88c012f22b9c917a39b1535\"\u003ekexec: Fix snprintf related compilation warnings\u003c/a\u003e","bodyMessageHtml":"This patch fixes the following snprintf related compilation warning\nseen currently with gcc versions 7 and 8 when kexec is compiled with\n-Wformat-truncation option:\n\n kexec/fs2dt.c:673:34: warning: ‘stdout-path’ directive output may be truncated writing 11 bytes into a region of size between 1 and 1024 [-Wformat-truncation=]\n snprintf(filename, MAXPATH, \"%sstdout-path\", pathname);\n ^~~~~~~~~~~\n kexec/fs2dt.c:673:3: note: ‘snprintf’ output between 12 and 1035 bytes into a destination of size 1024\n snprintf(filename, MAXPATH, \"%sstdout-path\", pathname);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n kexec/fs2dt.c:676:35: warning: ‘linux,stdout-path’ directive output may be truncated writing 17 bytes into a region of size between 1 and 1024 [-Wformat-truncation=]\n snprintf(filename, MAXPATH, \"%slinux,stdout-path\", pathname);\n ^~~~~~~~~~~~~~~~~\n kexec/fs2dt.c:676:4: note: ‘snprintf’ output between 18 and 1041 bytes into a destination of size 1024\n snprintf(filename, MAXPATH, \"%slinux,stdout-path\", pathname);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\n kexec/firmware_memmap.c:132:35: warning: ‘%s’ directive output may be truncated writing 5 bytes into a region of size between 0 and 4095 [-Wformat-truncation=]\n snprintf(filename, PATH_MAX, \"%s/%s\", entry, \"start\");\n ^~ ~~~~~~~\n kexec/firmware_memmap.c:132:2: note: ‘snprintf’ output between 7 and 4102 bytes into a destination of size 4096\n snprintf(filename, PATH_MAX, \"%s/%s\", entry, \"start\");\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n kexec/firmware_memmap.c:142:35: warning: ‘%s’ directive output may be truncated writing 3 bytes into a region of size between 0 and 4095 [-Wformat-truncation=]\n snprintf(filename, PATH_MAX, \"%s/%s\", entry, \"end\");\n ^~ ~~~~~\n kexec/firmware_memmap.c:142:2: note: ‘snprintf’ output between 5 and 4100 bytes into a destination of size 4096\n snprintf(filename, PATH_MAX, \"%s/%s\", entry, \"end\");\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n kexec/firmware_memmap.c:152:35: warning: ‘%s’ directive output may be truncated writing 4 bytes into a region of size between 0 and 4095 [-Wformat-truncation=]\n snprintf(filename, PATH_MAX, \"%s/%s\", entry, \"type\");\n ^~ ~~~~~~\n kexec/firmware_memmap.c:152:2: note: ‘snprintf’ output between 6 and 4101 bytes into a destination of size 4096\n snprintf(filename, PATH_MAX, \"%s/%s\", entry, \"type\");\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSince the simplest method to address the gcc warnings and possible\ntruncation would be to check the return value provided from snprintf\n(well there are other methods like using 'asnprintf' or using\n'open_memstream' function to create the FILE object, but these are more\nintrusive), so this patch does the same.\n\nCc: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\nCc: Eric Biederman \u0026lt;ebiederm@xmission.com\u0026gt;\nCc: kexec@lists.infradead.org\nSigned-off-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Bhupesh Sharma","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"15fc8cb3fa98decd0095c5f99af9f614a67e1611","url":"/mbgg/kexec-tools/commit/15fc8cb3fa98decd0095c5f99af9f614a67e1611","authoredDate":"2020-09-22T14:32:44.000+05:30","committedDate":"2020-09-29T18:17:29.000+02:00","shortMessage":"vmcore-dmesg/man page: Update the vmcore-dmesg man page","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"vmcore-dmesg/man page: Update the vmcore-dmesg man page\n\nThe vmcore-dmesg utility has been in usage for several years,\nand is pretty stable now.\n\nSo its useful now to modify its man page to indicate the same.\nAlso fix some minor formatting issues.\n\nSigned-off-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/15fc8cb3fa98decd0095c5f99af9f614a67e1611\"\u003evmcore-dmesg/man page: Update the vmcore-dmesg man page\u003c/a\u003e","bodyMessageHtml":"The vmcore-dmesg utility has been in usage for several years,\nand is pretty stable now.\n\nSo its useful now to modify its man page to indicate the same.\nAlso fix some minor formatting issues.\n\nSigned-off-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Bhupesh Sharma","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"9fd2189baf7adc85f8017145e789d3256f6fcd24","url":"/mbgg/kexec-tools/commit/9fd2189baf7adc85f8017145e789d3256f6fcd24","authoredDate":"2020-09-12T09:39:49.000+08:00","committedDate":"2020-09-29T18:14:33.000+02:00","shortMessage":"kexec-tools: Add some missing free() calls","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: Add some missing free() calls\n\nAdd some missing free() calls.\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/9fd2189baf7adc85f8017145e789d3256f6fcd24\"\u003ekexec-tools: Add some missing free() calls\u003c/a\u003e","bodyMessageHtml":"Add some missing free() calls.\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Youling Tang","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"ec537918a32564789dad14e32389afb2991d7f8d","url":"/mbgg/kexec-tools/commit/ec537918a32564789dad14e32389afb2991d7f8d","authoredDate":"2020-09-12T09:38:41.000+08:00","committedDate":"2020-09-29T18:12:17.000+02:00","shortMessage":"kexec-tools: Fix a prompt message when crashkernel is not reserved","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: Fix a prompt message when crashkernel is not reserved\n\nWhere Y specifies how much memory to reserve for the dump-capture kernel\nand X specifies the beginning of this reserved memory. So Y should be\nplaced before X.\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nReviewed-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/ec537918a32564789dad14e32389afb2991d7f8d\"\u003ekexec-tools: Fix a prompt message when crashkernel is not reserved\u003c/a\u003e","bodyMessageHtml":"Where Y specifies how much memory to reserve for the dump-capture kernel\nand X specifies the beginning of this reserved memory. So Y should be\nplaced before X.\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nReviewed-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Youling Tang","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Sep 25, 2020","commits":[{"oid":"7bd251654aadae993eb7d15ce1b39f61e9cee41a","url":"/mbgg/kexec-tools/commit/7bd251654aadae993eb7d15ce1b39f61e9cee41a","authoredDate":"2020-09-12T09:32:24.000+08:00","committedDate":"2020-09-25T07:55:22.000+02:00","shortMessage":"kexec-tools: mips: Remove commandline parameter \"mem\"","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: mips: Remove commandline parameter \u0026quot;mem\u0026quot;\n\n\u0026quot;mem=\u0026quot; indicating the memory region the new kernel can use to boot into.\nAnd passed to the dump-capture kernel by kernel commandline parameter\n\u0026quot;mem=\u0026quot;. But in the dump-capture kernel, we don’t need to use this parameter\nnow, so remove \u0026quot;mem\u0026quot; and don\u0026#39;t add \u0026quot;mem=\u0026quot; to new kernel commandline.\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/7bd251654aadae993eb7d15ce1b39f61e9cee41a\"\u003ekexec-tools: mips: Remove commandline parameter \"mem\"\u003c/a\u003e","bodyMessageHtml":"\"mem=\" indicating the memory region the new kernel can use to boot into.\nAnd passed to the dump-capture kernel by kernel commandline parameter\n\"mem=\". But in the dump-capture kernel, we don’t need to use this parameter\nnow, so remove \"mem\" and don't add \"mem=\" to new kernel commandline.\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Youling Tang","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Sep 2, 2020","commits":[{"oid":"a47b10c457eb6b353c81d15a4662cdf298e519ac","url":"/mbgg/kexec-tools/commit/a47b10c457eb6b353c81d15a4662cdf298e519ac","authoredDate":"2020-08-26T08:51:54.000+08:00","committedDate":"2020-09-02T18:28:57.000+02:00","shortMessage":"kexec/kexec.c: Add missing close() call","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec/kexec.c: Add missing close() call\n\nAdd missing close() call.\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nReviewed-by: Khalid Aziz \u0026lt;khalid@gonehiking.org\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/a47b10c457eb6b353c81d15a4662cdf298e519ac\"\u003ekexec/kexec.c: Add missing close() call\u003c/a\u003e","bodyMessageHtml":"Add missing close() call.\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nReviewed-by: Khalid Aziz \u0026lt;khalid@gonehiking.org\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Youling Tang","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"16168f8bff42e284b36e7af581a3b556bc94fd79","url":"/mbgg/kexec-tools/commit/16168f8bff42e284b36e7af581a3b556bc94fd79","authoredDate":"2020-08-25T08:29:57.000-06:00","committedDate":"2020-09-02T18:28:03.000+02:00","shortMessage":"AUTHORS: Update email address for Khalid","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"AUTHORS: Update email address for Khalid\n\nNew email address for Khalid Aziz.\n\nSigned-off-by: Khalid Aziz \u0026lt;khalid@gonehiking.org\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/16168f8bff42e284b36e7af581a3b556bc94fd79\"\u003eAUTHORS: Update email address for Khalid\u003c/a\u003e","bodyMessageHtml":"New email address for Khalid Aziz.\n\nSigned-off-by: Khalid Aziz \u0026lt;khalid@gonehiking.org\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"hikerockies","displayName":"Khalid Aziz","avatarUrl":"https://avatars.githubusercontent.com/u/6788153?v=4","path":"/hikerockies","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Aug 20, 2020","commits":[{"oid":"01144be42d1251aceb703299ab9cdeb894c96878","url":"/mbgg/kexec-tools/commit/01144be42d1251aceb703299ab9cdeb894c96878","authoredDate":"2020-08-13T13:31:52.000+08:00","committedDate":"2020-08-20T17:29:53.000+02:00","shortMessage":"MIPS: Fix compile warnnings in kexec-elf-mips.c","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"MIPS: Fix compile warnnings in kexec-elf-mips.c\n\nFix the following warnings:\n\nkexec/arch/mips/kexec-elf-mips.c:161:41: warning: passing argument 3 of\n‘dtb_set_initrd’ makes integer from pointer without a cast\ndtb_set_initrd(\u0026amp;dtb_buf, \u0026amp;dtb_length, initrd_buf, initrd_buf + initrd_size);\n ^\nIn file included from kexec/arch/mips/kexec-elf-mips.c:33:0:\nkexec/arch/mips/../../dt-ops.h:6:5: note: expected ‘off_t’ but argument is\nof type ‘char *’\nint dtb_set_initrd(char **dtb, off_t *dtb_size, off_t start, off_t end);\n ^\n\nkexec/arch/mips/kexec-elf-mips.c:161:53: warning: passing argument 4 of\n‘dtb_set_initrd’ makes integer from pointer without a cast\ndtb_set_initrd(\u0026amp;dtb_buf, \u0026amp;dtb_length, initrd_buf, initrd_buf + initrd_size);\n ^\nIn file included from kexec/arch/mips/kexec-elf-mips.c:33:0:\nkexec/arch/mips/../../dt-ops.h:6:5: note: expected ‘off_t’ but argument is\nof type ‘char *’\nint dtb_set_initrd(char **dtb, off_t *dtb_size, off_t start, off_t end);\n ^\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/01144be42d1251aceb703299ab9cdeb894c96878\"\u003eMIPS: Fix compile warnnings in kexec-elf-mips.c\u003c/a\u003e","bodyMessageHtml":"Fix the following warnings:\n\nkexec/arch/mips/kexec-elf-mips.c:161:41: warning: passing argument 3 of\n‘dtb_set_initrd’ makes integer from pointer without a cast\ndtb_set_initrd(\u0026amp;dtb_buf, \u0026amp;dtb_length, initrd_buf, initrd_buf + initrd_size);\n ^\nIn file included from kexec/arch/mips/kexec-elf-mips.c:33:0:\nkexec/arch/mips/../../dt-ops.h:6:5: note: expected ‘off_t’ but argument is\nof type ‘char *’\nint dtb_set_initrd(char **dtb, off_t *dtb_size, off_t start, off_t end);\n ^\n\nkexec/arch/mips/kexec-elf-mips.c:161:53: warning: passing argument 4 of\n‘dtb_set_initrd’ makes integer from pointer without a cast\ndtb_set_initrd(\u0026amp;dtb_buf, \u0026amp;dtb_length, initrd_buf, initrd_buf + initrd_size);\n ^\nIn file included from kexec/arch/mips/kexec-elf-mips.c:33:0:\nkexec/arch/mips/../../dt-ops.h:6:5: note: expected ‘off_t’ but argument is\nof type ‘char *’\nint dtb_set_initrd(char **dtb, off_t *dtb_size, off_t start, off_t end);\n ^\n\nSigned-off-by: Youling Tang \u0026lt;tangyouling@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Youling Tang","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Aug 10, 2020","commits":[{"oid":"24884d12d0a494b59c534af3ef067d7f7a0e075f","url":"/mbgg/kexec-tools/commit/24884d12d0a494b59c534af3ef067d7f7a0e075f","authoredDate":"2020-07-10T17:11:44.000+08:00","committedDate":"2020-08-10T13:48:47.000+02:00","shortMessage":"mips: kexec-elf-mips: fix not free in elf_mips_load()","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"mips: kexec-elf-mips: fix not free in elf_mips_load()\n\nIn the function elf_mips_load(), crash_cmdline was alloced memory.\nBut it seems to forget to free it when last used at line 131.\n\nSigned-off-by: Jinyang He \u0026lt;hejinyang@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/24884d12d0a494b59c534af3ef067d7f7a0e075f\"\u003emips: kexec-elf-mips: fix not free in elf_mips_load()\u003c/a\u003e","bodyMessageHtml":"In the function elf_mips_load(), crash_cmdline was alloced memory.\nBut it seems to forget to free it when last used at line 131.\n\nSigned-off-by: Jinyang He \u0026lt;hejinyang@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"MQ-mengqing","displayName":"Jinyang He","avatarUrl":"https://avatars.githubusercontent.com/u/48644034?v=4","path":"/MQ-mengqing","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"12e643a7dc65cc6d70f6d207867b6db943c6138b","url":"/mbgg/kexec-tools/commit/12e643a7dc65cc6d70f6d207867b6db943c6138b","authoredDate":"2020-07-10T17:11:32.000+08:00","committedDate":"2020-08-10T13:45:19.000+02:00","shortMessage":"kexec-tools: Check callback first in kexec_iomem_for_each_line()","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: Check callback first in kexec_iomem_for_each_line()\n\nIn the function kexec_iomem_for_each_line(), it is better to\ncheck the callback first, it can return directly if the callback\nis NULL.\n\nSigned-off-by: Jinyang He \u0026lt;hejinyang@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/12e643a7dc65cc6d70f6d207867b6db943c6138b\"\u003ekexec-tools: Check callback first in kexec_iomem_for_each_line()\u003c/a\u003e","bodyMessageHtml":"In the function kexec_iomem_for_each_line(), it is better to\ncheck the callback first, it can return directly if the callback\nis NULL.\n\nSigned-off-by: Jinyang He \u0026lt;hejinyang@loongson.cn\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"MQ-mengqing","displayName":"Jinyang He","avatarUrl":"https://avatars.githubusercontent.com/u/48644034?v=4","path":"/MQ-mengqing","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Jun 6, 2020","commits":[{"oid":"7a576da125f14bc9b0c7fc4ecf41fd740f6f56b0","url":"/mbgg/kexec-tools/commit/7a576da125f14bc9b0c7fc4ecf41fd740f6f56b0","authoredDate":"2020-06-02T12:40:34.000+02:00","committedDate":"2020-06-06T15:22:30.000+02:00","shortMessage":"arm: Increase zImage length after getting the tag","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"arm: Increase zImage length after getting the tag\n\nIncrease the size of the zImage after seeking for the tag to avoid\nreading past the end of the supplied buffer should there be not tag\nin the zImage.\n\nFixes: f57f0bf8975d24fe1e7c4936fdfb5c3b123ab75f\nSigned-off-by: Łukasz Stelmach \u0026lt;l.stelmach@samsung.com\u0026gt;\nCc: Russell King \u0026lt;rmk@armlinux.org.uk\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/7a576da125f14bc9b0c7fc4ecf41fd740f6f56b0\"\u003earm: Increase zImage length after getting the tag\u003c/a\u003e","bodyMessageHtml":"Increase the size of the zImage after seeking for the tag to avoid\nreading past the end of the supplied buffer should there be not tag\nin the zImage.\n\nFixes: \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/mbgg/kexec-tools/commit/f57f0bf8975d24fe1e7c4936fdfb5c3b123ab75f/hovercard\" href=\"https://github.com/mbgg/kexec-tools/commit/f57f0bf8975d24fe1e7c4936fdfb5c3b123ab75f\"\u003e\u003ctt\u003ef57f0bf\u003c/tt\u003e\u003c/a\u003e\nSigned-off-by: Łukasz Stelmach \u0026lt;l.stelmach@samsung.com\u0026gt;\nCc: Russell King \u0026lt;rmk@armlinux.org.uk\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Łukasz Stelmach","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"f22b6aabc6e1082f7c7a84c68de00ba9af67f218","url":"/mbgg/kexec-tools/commit/f22b6aabc6e1082f7c7a84c68de00ba9af67f218","authoredDate":"2020-06-02T10:01:59.000+05:30","committedDate":"2020-06-06T15:20:34.000+02:00","shortMessage":"kexec-tools: fix the unintended fallthrough when '-d' option is used","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: fix the unintended fallthrough when \u0026#39;-d\u0026#39; option is used\n\nFixes: 28d4ab532808 (\u0026quot;Add generic debug option\u0026quot;)\nCc: Cong Wang \u0026lt;xiyou.wangcong@gmail.com\u0026gt;\nSigned-off-by: Hari Bathini \u0026lt;hbathini@linux.ibm.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/f22b6aabc6e1082f7c7a84c68de00ba9af67f218\"\u003ekexec-tools: fix the unintended fallthrough when '-d' option is used\u003c/a\u003e","bodyMessageHtml":"Fixes: \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/mbgg/kexec-tools/commit/28d4ab53280853d2aeefdfb7c369331e89ab9ac2/hovercard\" href=\"https://github.com/mbgg/kexec-tools/commit/28d4ab53280853d2aeefdfb7c369331e89ab9ac2\"\u003e\u003ctt\u003e28d4ab5\u003c/tt\u003e\u003c/a\u003e (\"Add generic debug option\")\nCc: Cong Wang \u0026lt;xiyou.wangcong@gmail.com\u0026gt;\nSigned-off-by: Hari Bathini \u0026lt;hbathini@linux.ibm.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"hbathini","displayName":"Hari Bathini","avatarUrl":"https://avatars.githubusercontent.com/u/22388959?v=4","path":"/hbathini","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Apr 24, 2020","commits":[{"oid":"74c7c369f8c75c665605e117c14816bb060ed91c","url":"/mbgg/kexec-tools/commit/74c7c369f8c75c665605e117c14816bb060ed91c","authoredDate":"2020-04-22T21:45:04.000+02:00","committedDate":"2020-04-24T11:38:25.000+02:00","shortMessage":"arm: redefine OPT_APPEND and OPT_RAMDISK","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"arm: redefine OPT_APPEND and OPT_RAMDISK\n\nRedefine OPT_APPEND to avoid clash with OPT_KEXEC_SYSCALL_AUTO.\nRedefine OPT_RAMDISK to avoid such problems in the future\n\nMinor cleanup in HPPA too.\n\nSigned-off-by: Łukasz Stelmach \u0026lt;l.stelmach@samsung.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/74c7c369f8c75c665605e117c14816bb060ed91c\"\u003earm: redefine OPT_APPEND and OPT_RAMDISK\u003c/a\u003e","bodyMessageHtml":"Redefine OPT_APPEND to avoid clash with OPT_KEXEC_SYSCALL_AUTO.\nRedefine OPT_RAMDISK to avoid such problems in the future\n\nMinor cleanup in HPPA too.\n\nSigned-off-by: Łukasz Stelmach \u0026lt;l.stelmach@samsung.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Łukasz Stelmach","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Apr 7, 2020","commits":[{"oid":"5dc72ded6050a5bb161e3b832867e660c9ca009e","url":"/mbgg/kexec-tools/commit/5dc72ded6050a5bb161e3b832867e660c9ca009e","authoredDate":"2020-04-03T13:19:16.000+02:00","committedDate":"2020-04-07T14:00:57.000+02:00","shortMessage":"kexec-tools: s390: Reset kernel command line on syscall fallback","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: s390: Reset kernel command line on syscall fallback\n\nThe command line is duplicated on s390 if kexec_file_load(2) is not\nimplemented. That\u0026#39;s because the corresponding variable is not reset\nto an empty string before re-parsing the kexec command line.\n\nFixes: 9cf721279f6c (\u0026quot;Reset getopt before falling back to legacy syscall\u0026quot;)\nSigned-off-by: Petr Tesarik \u0026lt;ptesarik@suse.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/5dc72ded6050a5bb161e3b832867e660c9ca009e\"\u003ekexec-tools: s390: Reset kernel command line on syscall fallback\u003c/a\u003e","bodyMessageHtml":"The command line is duplicated on s390 if kexec_file_load(2) is not\nimplemented. That's because the corresponding variable is not reset\nto an empty string before re-parsing the kexec command line.\n\nFixes: \u003ca class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/mbgg/kexec-tools/commit/9cf721279f6cb0dec09c8752e471f15fb662406b/hovercard\" href=\"https://github.com/mbgg/kexec-tools/commit/9cf721279f6cb0dec09c8752e471f15fb662406b\"\u003e\u003ctt\u003e9cf7212\u003c/tt\u003e\u003c/a\u003e (\"Reset getopt before falling back to legacy syscall\")\nSigned-off-by: Petr Tesarik \u0026lt;ptesarik@suse.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"ptesarik","displayName":"Petr Tesarik","avatarUrl":"https://avatars.githubusercontent.com/u/605029?v=4","path":"/ptesarik","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"65441fbf8766046a0499edff8a893dc8143f6abd","url":"/mbgg/kexec-tools/commit/65441fbf8766046a0499edff8a893dc8143f6abd","authoredDate":"2020-04-01T18:57:17.000+02:00","committedDate":"2020-04-07T13:53:41.000+02:00","shortMessage":"kexec-xen: Introduce --exec-live-update to trigger a live update","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-xen: Introduce --exec-live-update to trigger a live update\n\nThis signals xen to do a KEXEC_TYPE_LIVE_UPDATE kexec operation.\n\nSigned-off-by: Varad Gautam \u0026lt;vrd@amazon.de\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/65441fbf8766046a0499edff8a893dc8143f6abd\"\u003ekexec-xen: Introduce --exec-live-update to trigger a live update\u003c/a\u003e","bodyMessageHtml":"This signals xen to do a KEXEC_TYPE_LIVE_UPDATE kexec operation.\n\nSigned-off-by: Varad Gautam \u0026lt;vrd@amazon.de\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Varad Gautam","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"b13984c6f9ec7fdd322e8d981defc2b846717bbc","url":"/mbgg/kexec-tools/commit/b13984c6f9ec7fdd322e8d981defc2b846717bbc","authoredDate":"2020-04-01T18:57:16.000+02:00","committedDate":"2020-04-07T13:53:32.000+02:00","shortMessage":"kexec: Introduce --load-live-update for xen","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec: Introduce --load-live-update for xen\n\nSupport loading a live update image for xen from kexec userspace.\nFor a multiboot2 Elf on a xen setup, this will:\n- load the Elf into KEXEC_RANGE_MA_XEN\n- load purgatory and modules into KEXEC_RANGE_MA_LIVEUPDATE\n- append the Elf cmdline with \u0026quot; liveupdate=\u0026lt;size\u0026gt;@\u0026lt;addr\u0026gt;\n\nv2: define xen related symbols outside of HAVE_LIBXENCTRL\n\nSigned-off-by: Varad Gautam \u0026lt;vrd@amazon.de\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/b13984c6f9ec7fdd322e8d981defc2b846717bbc\"\u003ekexec: Introduce --load-live-update for xen\u003c/a\u003e","bodyMessageHtml":"Support loading a live update image for xen from kexec userspace.\nFor a multiboot2 Elf on a xen setup, this will:\n- load the Elf into KEXEC_RANGE_MA_XEN\n- load purgatory and modules into KEXEC_RANGE_MA_LIVEUPDATE\n- append the Elf cmdline with \" liveupdate=\u0026lt;size\u0026gt;@\u0026lt;addr\u0026gt;\n\nv2: define xen related symbols outside of HAVE_LIBXENCTRL\n\nSigned-off-by: Varad Gautam \u0026lt;vrd@amazon.de\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Varad Gautam","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"41a9b98fff4d3a45ae5c6ffe6a10999fafd3e4e6","url":"/mbgg/kexec-tools/commit/41a9b98fff4d3a45ae5c6ffe6a10999fafd3e4e6","authoredDate":"2020-04-01T18:57:15.000+02:00","committedDate":"2020-04-07T13:53:17.000+02:00","shortMessage":"kexec-xen: Introduce xen_get_kexec_range to wrap xc_kexec_get_range","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-xen: Introduce xen_get_kexec_range to wrap xc_kexec_get_range\n\nAnd convert all callers of xc_kexec_get_range to use this. Allows reusing\nsanity checks for other KEXEC_RANGEs\n\nv2: define xen_get_kexec_range outside of HAVE_LIBXENCTRL\n\nSigned-off-by: Varad Gautam \u0026lt;vrd@amazon.de\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/41a9b98fff4d3a45ae5c6ffe6a10999fafd3e4e6\"\u003ekexec-xen: Introduce xen_get_kexec_range to wrap xc_kexec_get_range\u003c/a\u003e","bodyMessageHtml":"And convert all callers of xc_kexec_get_range to use this. Allows reusing\nsanity checks for other KEXEC_RANGEs\n\nv2: define xen_get_kexec_range outside of HAVE_LIBXENCTRL\n\nSigned-off-by: Varad Gautam \u0026lt;vrd@amazon.de\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Varad Gautam","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Apr 1, 2020","commits":[{"oid":"cc087b11462af9f971a2c090d07e8d780a867b50","url":"/mbgg/kexec-tools/commit/cc087b11462af9f971a2c090d07e8d780a867b50","authoredDate":"2020-01-29T13:38:19.000+08:00","committedDate":"2020-04-01T14:49:07.000+02:00","shortMessage":"kexec-tools: Remove duplicated variable declarations","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: Remove duplicated variable declarations\n\nWhen building kexec-tools for Fedora 32, following error is observed:\n\n/usr/bin/ld: kexec/arch/x86_64/kexec-bzImage64.o:(.bss+0x0): multiple definition of `bzImage_support_efi_boot\u0026#39;;\nkexec/arch/i386/kexec-bzImage.o:(.bss+0x0): first defined here\n\n/builddir/build/BUILD/kexec-tools-2.0.20/kexec/arch/arm/../../fs2dt.h:33: multiple definition of `my_debug\u0026#39;;\nkexec/fs2dt.o:/builddir/build/BUILD/kexec-tools-2.0.20/kexec/fs2dt.h:33: first defined here\n\n/builddir/build/BUILD/kexec-tools-2.0.20/kexec/arch/arm64/kexec-arm64.h:68: multiple definition of `arm64_mem\u0026#39;;\nkexec/fs2dt.o:/builddir/build/BUILD/kexec-tools-2.0.20/././kexec/arch/arm64/kexec-arm64.h:68: first defined here\n\n/builddir/build/BUILD/kexec-tools-2.0.20/kexec/arch/arm64/kexec-arm64.h:54: multiple definition of `initrd_size\u0026#39;;\nkexec/fs2dt.o:/builddir/build/BUILD/kexec-tools-2.0.20/././kexec/arch/arm64/kexec-arm64.h:54: first defined here\n\n/builddir/build/BUILD/kexec-tools-2.0.20/kexec/arch/arm64/kexec-arm64.h:53: multiple definition of `initrd_base\u0026#39;;\nkexec/fs2dt.o:/builddir/build/BUILD/kexec-tools-2.0.20/././kexec/arch/arm64/kexec-arm64.h:53: first defined here\n\nAnd apparently, these variables are wrongly declared multiple times. So\nremove duplicated declaration.\n\nSigned-off-by: Kairui Song \u0026lt;kasong@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/cc087b11462af9f971a2c090d07e8d780a867b50\"\u003ekexec-tools: Remove duplicated variable declarations\u003c/a\u003e","bodyMessageHtml":"When building kexec-tools for Fedora 32, following error is observed:\n\n/usr/bin/ld: kexec/arch/x86_64/kexec-bzImage64.o:(.bss+0x0): multiple definition of `bzImage_support_efi_boot';\nkexec/arch/i386/kexec-bzImage.o:(.bss+0x0): first defined here\n\n/builddir/build/BUILD/kexec-tools-2.0.20/kexec/arch/arm/../../fs2dt.h:33: multiple definition of `my_debug';\nkexec/fs2dt.o:/builddir/build/BUILD/kexec-tools-2.0.20/kexec/fs2dt.h:33: first defined here\n\n/builddir/build/BUILD/kexec-tools-2.0.20/kexec/arch/arm64/kexec-arm64.h:68: multiple definition of `arm64_mem';\nkexec/fs2dt.o:/builddir/build/BUILD/kexec-tools-2.0.20/././kexec/arch/arm64/kexec-arm64.h:68: first defined here\n\n/builddir/build/BUILD/kexec-tools-2.0.20/kexec/arch/arm64/kexec-arm64.h:54: multiple definition of `initrd_size';\nkexec/fs2dt.o:/builddir/build/BUILD/kexec-tools-2.0.20/././kexec/arch/arm64/kexec-arm64.h:54: first defined here\n\n/builddir/build/BUILD/kexec-tools-2.0.20/kexec/arch/arm64/kexec-arm64.h:53: multiple definition of `initrd_base';\nkexec/fs2dt.o:/builddir/build/BUILD/kexec-tools-2.0.20/././kexec/arch/arm64/kexec-arm64.h:53: first defined here\n\nAnd apparently, these variables are wrongly declared multiple times. So\nremove duplicated declaration.\n\nSigned-off-by: Kairui Song \u0026lt;kasong@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"ryncsn","displayName":"Kairui Song","avatarUrl":"https://avatars.githubusercontent.com/u/8090831?v=4","path":"/ryncsn","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"cbbee58d9f57765e50b12ce18aabbe90390ec640","url":"/mbgg/kexec-tools/commit/cbbee58d9f57765e50b12ce18aabbe90390ec640","authoredDate":"2020-03-03T03:56:49.000Z","committedDate":"2020-04-01T14:44:35.000+02:00","shortMessage":"Removing condition that will never be met after calls xmalloc and xrealloc","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"Removing condition that will never be met after calls xmalloc and xrealloc\n\nHi,\n\nLooking in the kexec-tools code I found these conditions that\nseems will never be met. Not sure if that was intentional for explicitity,\nif it was the case, please disconsider this patch.\n\nxmalloc and xrealloc when fails calls die() that calls exit(1).\nChecks for if(!memory) after they are called will never be met that\ncondition, since the process will be exited after an allocation fail.\n\nSigned-off-by: Leonidas S. Barbosa \u0026lt;kirotawa@gmail.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/cbbee58d9f57765e50b12ce18aabbe90390ec640\"\u003eRemoving condition that will never be met after calls xmalloc and xrealloc\u003c/a\u003e","bodyMessageHtml":"Hi,\n\nLooking in the kexec-tools code I found these conditions that\nseems will never be met. Not sure if that was intentional for explicitity,\nif it was the case, please disconsider this patch.\n\nxmalloc and xrealloc when fails calls die() that calls exit(1).\nChecks for if(!memory) after they are called will never be met that\ncondition, since the process will be exited after an allocation fail.\n\nSigned-off-by: Leonidas S. Barbosa \u0026lt;kirotawa@gmail.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"kirotawa","displayName":"Leonidas S. Barbosa","avatarUrl":"https://avatars.githubusercontent.com/u/476400?v=4","path":"/kirotawa","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"618799e90566e22554584644e496ff95f425ac48","url":"/mbgg/kexec-tools/commit/618799e90566e22554584644e496ff95f425ac48","authoredDate":"2020-02-24T14:36:55.000+08:00","committedDate":"2020-04-01T14:42:35.000+02:00","shortMessage":"kexec: support parsing the string \"Reserved\" to get the correct e820 reserved region","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec: support parsing the string \u0026quot;Reserved\u0026quot; to get the correct e820 reserved region\n\nWhen loading kernel and initramfs for kexec, kexec-tools could get the\ne820 reserved region from \u0026quot;/proc/iomem\u0026quot; in order to rebuild the e820\nranges for kexec kernel, but there may be the string \u0026quot;Reserved\u0026quot; in the\n\u0026quot;/proc/iomem\u0026quot;, which caused the failure of parsing. For example:\n\n #cat /proc/iomem|grep -i reserved\n00000000-00000fff : Reserved\n7f338000-7f34dfff : Reserved\n7f3cd000-8fffffff : Reserved\nf17f0000-f17f1fff : Reserved\nfe000000-ffffffff : Reserved\n\nCurrently, kexec-tools can not handle the above case because the memcmp()\nis case sensitive when comparing the string.\n\nSo, let\u0026#39;s fix this corner and make sure that the string \u0026quot;reserved\u0026quot; and\n\u0026quot;Reserved\u0026quot; in the \u0026quot;/proc/iomem\u0026quot; are both parsed appropriately.\n\nSigned-off-by: Lianbo Jiang \u0026lt;lijiang@redhat.com\u0026gt;\nAcked-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/618799e90566e22554584644e496ff95f425ac48\"\u003ekexec: support parsing the string \"Reserved\" to get the correct e820 reserved region\u003c/a\u003e","bodyMessageHtml":"When loading kernel and initramfs for kexec, kexec-tools could get the\ne820 reserved region from \"/proc/iomem\" in order to rebuild the e820\nranges for kexec kernel, but there may be the string \"Reserved\" in the\n\"/proc/iomem\", which caused the failure of parsing. For example:\n\n #cat /proc/iomem|grep -i reserved\n00000000-00000fff : Reserved\n7f338000-7f34dfff : Reserved\n7f3cd000-8fffffff : Reserved\nf17f0000-f17f1fff : Reserved\nfe000000-ffffffff : Reserved\n\nCurrently, kexec-tools can not handle the above case because the memcmp()\nis case sensitive when comparing the string.\n\nSo, let's fix this corner and make sure that the string \"reserved\" and\n\"Reserved\" in the \"/proc/iomem\" are both parsed appropriately.\n\nSigned-off-by: Lianbo Jiang \u0026lt;lijiang@redhat.com\u0026gt;\nAcked-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"lian-bo","displayName":"Lianbo Jiang","avatarUrl":"https://avatars.githubusercontent.com/u/37111043?v=4","path":"/lian-bo","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"9cf721279f6cb0dec09c8752e471f15fb662406b","url":"/mbgg/kexec-tools/commit/9cf721279f6cb0dec09c8752e471f15fb662406b","authoredDate":"2020-03-13T15:09:29.000+01:00","committedDate":"2020-04-01T14:39:27.000+02:00","shortMessage":"kexec-tools: Reset getopt before falling back to legacy syscall","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: Reset getopt before falling back to legacy syscall\n\nThe modules may need to parse the arguments again after\nkexec_file_load(2) failed, but getopt is not reset.\n\nThis change fixes the --initrd option on s390x. Without this patch,\nit will fail to load the initrd on kernels that do not implement\nkexec_file_load(2).\n\nSigned-off-by: Petr Tesarik \u0026lt;ptesarik@suse.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/9cf721279f6cb0dec09c8752e471f15fb662406b\"\u003ekexec-tools: Reset getopt before falling back to legacy syscall\u003c/a\u003e","bodyMessageHtml":"The modules may need to parse the arguments again after\nkexec_file_load(2) failed, but getopt is not reset.\n\nThis change fixes the --initrd option on s390x. Without this patch,\nit will fail to load the initrd on kernels that do not implement\nkexec_file_load(2).\n\nSigned-off-by: Petr Tesarik \u0026lt;ptesarik@suse.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"ptesarik","displayName":"Petr Tesarik","avatarUrl":"https://avatars.githubusercontent.com/u/605029?v=4","path":"/ptesarik","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"4f77da6340356de40af70473d3c3ae6ec663fbdf","url":"/mbgg/kexec-tools/commit/4f77da6340356de40af70473d3c3ae6ec663fbdf","authoredDate":"2020-03-13T15:09:28.000+01:00","committedDate":"2020-04-01T14:37:11.000+02:00","shortMessage":"kexec-tools: Fix kexec_file_load(2) error handling","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec-tools: Fix kexec_file_load(2) error handling\n\nThe handling of kexec_file_load() error conditions needs some\nimprovement.\n\nFirst, on failure, the system call itself returns -1 and sets\nerrno. It is wrong to check the return value itself.\n\nSecond, do_kexec_file_load() mixes different types of error\ncodes (-1, return value of a load method, negative kernel error\nnumber). Let it always return one of the reason codes defined in\nkexec/kexec.h.\n\nThird, the caller of do_kexec_file_load() cannot know what exactly\nfailed inside that function, so it should not check errno directly.\nAll it needs to know is whether it makes sense to fall back to the\nother syscall. Add an error code for that purpose (EFALLBACK), and\nlet do_kexec_file_load() decide.\n\nFourth, do_kexec_file_load() should not print any error message if\nit returns EFALLBACK, because the fallback syscall may succeed\nlater, and the user is confused whether the command failed, or not.\nMove the error message towards the end of main().\n\nSigned-off-by: Petr Tesarik \u0026lt;ptesarik@suse.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/4f77da6340356de40af70473d3c3ae6ec663fbdf\"\u003ekexec-tools: Fix kexec_file_load(2) error handling\u003c/a\u003e","bodyMessageHtml":"The handling of kexec_file_load() error conditions needs some\nimprovement.\n\nFirst, on failure, the system call itself returns -1 and sets\nerrno. It is wrong to check the return value itself.\n\nSecond, do_kexec_file_load() mixes different types of error\ncodes (-1, return value of a load method, negative kernel error\nnumber). Let it always return one of the reason codes defined in\nkexec/kexec.h.\n\nThird, the caller of do_kexec_file_load() cannot know what exactly\nfailed inside that function, so it should not check errno directly.\nAll it needs to know is whether it makes sense to fall back to the\nother syscall. Add an error code for that purpose (EFALLBACK), and\nlet do_kexec_file_load() decide.\n\nFourth, do_kexec_file_load() should not print any error message if\nit returns EFALLBACK, because the fallback syscall may succeed\nlater, and the user is confused whether the command failed, or not.\nMove the error message towards the end of main().\n\nSigned-off-by: Petr Tesarik \u0026lt;ptesarik@suse.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"ptesarik","displayName":"Petr Tesarik","avatarUrl":"https://avatars.githubusercontent.com/u/605029?v=4","path":"/ptesarik","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"a4afe68d9afaeb219c734e73bc4042ac3aa64836","url":"/mbgg/kexec-tools/commit/a4afe68d9afaeb219c734e73bc4042ac3aa64836","authoredDate":"2020-03-04T20:27:11.000-03:00","committedDate":"2020-04-01T14:30:04.000+02:00","shortMessage":"crashdump-ppc64: crashkernel-base and crashkernel-size are big-endian","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"crashdump-ppc64: crashkernel-base and crashkernel-size are big-endian\n\nWhen reading the device-tree exported crashkernel-base and\ncrashkernel-size, their values should be converted from big-endian to the\nCPU byte order.\n\nThese is the output of running kexec --print-ckr-size on a little-endian\nppc64 box.\n\n$ kexec --print-ckr-size\n137438953472\n$ kexec --print-ckr-size\n536870912\n\nSigned-off-by: Thadeu Lima de Souza Cascardo \u0026lt;cascardo@canonical.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/a4afe68d9afaeb219c734e73bc4042ac3aa64836\"\u003ecrashdump-ppc64: crashkernel-base and crashkernel-size are big-endian\u003c/a\u003e","bodyMessageHtml":"When reading the device-tree exported crashkernel-base and\ncrashkernel-size, their values should be converted from big-endian to the\nCPU byte order.\n\nThese is the output of running kexec --print-ckr-size on a little-endian\nppc64 box.\n\n$ kexec --print-ckr-size\n137438953472\n$ kexec --print-ckr-size\n536870912\n\nSigned-off-by: Thadeu Lima de Souza Cascardo \u0026lt;cascardo@canonical.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"Thadeu Lima de Souza Cascardo","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isG
10000
itHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]},{"title":"Jan 3, 2020","commits":[{"oid":"2c9f26ed20a791a7df0182ba82e93abb52f5a615","url":"/mbgg/kexec-tools/commit/2c9f26ed20a791a7df0182ba82e93abb52f5a615","authoredDate":"2019-11-18T12:52:15.000+13:00","committedDate":"2020-01-03T10:10:15.000+01:00","shortMessage":"kexec: build multiboot2 for i386","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"kexec: build multiboot2 for i386\n\nThis addresses the following compilation issues when building for i386.\n\n kexec/arch/i386/kexec-x86.c:39:22: error: \u0026#39;multiboot2_x86_probe\u0026#39; undeclared here (not in a function); did you mean \u0026#39;multiboot_x86_probe\u0026#39;?\n { \u0026quot;multiboot2-x86\u0026quot;, multiboot2_x86_probe, multiboot2_x86_load,\n ^~~~~~~~~~~~~~~~~~~~\n multiboot_x86_probe\n kexec/arch/i386/kexec-x86.c:39:44: error: \u0026#39;multiboot2_x86_load\u0026#39; undeclared here (not in a function); did you mean \u0026#39;multiboot_x86_load\u0026#39;?\n { \u0026quot;multiboot2-x86\u0026quot;, multiboot2_x86_probe, multiboot2_x86_load,\n ^~~~~~~~~~~~~~~~~~~\n multiboot_x86_load\n kexec/arch/i386/kexec-x86.c:40:4: error: \u0026#39;multiboot2_x86_usage\u0026#39; undeclared here (not in a function); did you mean \u0026#39;multiboot_x86_usage\u0026#39;?\n multiboot2_x86_usage },\n ^~~~~~~~~~~~~~~~~~~~\n multiboot_x86_usage\n make: *** [Makefile:114: kexec/arch/i386/kexec-x86.o] Error 1\n make: *** Waiting for unfinished jobs....\n\nSigned-off-by: Chris Packham \u0026lt;chris.packham@alliedtelesis.co.nz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/2c9f26ed20a791a7df0182ba82e93abb52f5a615\"\u003ekexec: build multiboot2 for i386\u003c/a\u003e","bodyMessageHtml":"This addresses the following compilation issues when building for i386.\n\n kexec/arch/i386/kexec-x86.c:39:22: error: 'multiboot2_x86_probe' undeclared here (not in a function); did you mean 'multiboot_x86_probe'?\n { \"multiboot2-x86\", multiboot2_x86_probe, multiboot2_x86_load,\n ^~~~~~~~~~~~~~~~~~~~\n multiboot_x86_probe\n kexec/arch/i386/kexec-x86.c:39:44: error: 'multiboot2_x86_load' undeclared here (not in a function); did you mean 'multiboot_x86_load'?\n { \"multiboot2-x86\", multiboot2_x86_probe, multiboot2_x86_load,\n ^~~~~~~~~~~~~~~~~~~\n multiboot_x86_load\n kexec/arch/i386/kexec-x86.c:40:4: error: 'multiboot2_x86_usage' undeclared here (not in a function); did you mean 'multiboot_x86_usage'?\n multiboot2_x86_usage },\n ^~~~~~~~~~~~~~~~~~~~\n multiboot_x86_usage\n make: *** [Makefile:114: kexec/arch/i386/kexec-x86.o] Error 1\n make: *** Waiting for unfinished jobs....\n\nSigned-off-by: Chris Packham \u0026lt;chris.packham@alliedtelesis.co.nz\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"cpackham-atlnz","displayName":"Chris Packham","avatarUrl":"https://avatars.githubusercontent.com/u/85916201?v=4","path":"/cpackham-atlnz","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"66b151d3ab7dc6bb35f589a4596c426fdb3e4370","url":"/mbgg/kexec-tools/commit/66b151d3ab7dc6bb35f589a4596c426fdb3e4370","authoredDate":"2019-11-08T12:08:54.000-06:00","committedDate":"2020-01-03T09:47:43.000+01:00","shortMessage":"ARM: Use mmap for zImage initrd","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"ARM: Use mmap for zImage initrd\n\nWe use a large initrd that maxes out our available RAM when loading\nkexec. The problem can be mitigated by using slurp_file_mmap(), which\navoids creating a copy of the initrd. The initrd does not use free,\nrealloc, etc, so it should be safe to use.\n\nSigned-off-by: Brandon Maier \u0026lt;brandon.maier@rockwellcollins.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/66b151d3ab7dc6bb35f589a4596c426fdb3e4370\"\u003eARM: Use mmap for zImage initrd\u003c/a\u003e","bodyMessageHtml":"We use a large initrd that maxes out our available RAM when loading\nkexec. The problem can be mitigated by using slurp_file_mmap(), which\navoids creating a copy of the initrd. The initrd does not use free,\nrealloc, etc, so it should be safe to use.\n\nSigned-off-by: Brandon Maier \u0026lt;brandon.maier@rockwellcollins.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":"blmaier","displayName":"Brandon Maier","avatarUrl":"https://avatars.githubusercontent.com/u/7141086?v=4","path":"/blmaier","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"2572b8d702e452624bdb8d7b7c39f458e7dcf2ce","url":"/mbgg/kexec-tools/commit/2572b8d702e452624bdb8d7b7c39f458e7dcf2ce","authoredDate":"2019-12-18T11:42:32.000-05:00","committedDate":"2020-01-03T09:36:22.000+01:00","shortMessage":"arm64: kdump: deal with a lot of resource entries in /proc/iomem","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"arm64: kdump: deal with a lot of resource entries in /proc/iomem\n\nAs described in the commit (\u0026quot;arm64: kexec: allocate memory space avoiding\nreserved regions\u0026quot;), /proc/iomem now has a lot of \u0026quot;reserved\u0026quot; entries, and\nit\u0026#39;s not just enough to have a fixed size of memory range array.\n\nWith this patch, kdump is allowed to handle arbitrary number of memory\nranges, using mem_regions_alloc_and_xxx() functions.\n\nSigned-off-by: AKASHI Takahiro \u0026lt;takahiro.akashi@linaro.org\u0026gt;\nTested-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nTested-by: Masayoshi Mizuma \u0026lt;m.mizuma@jp.fujitsu.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/2572b8d702e452624bdb8d7b7c39f458e7dcf2ce\"\u003earm64: kdump: deal with a lot of resource entries in /proc/iomem\u003c/a\u003e","bodyMessageHtml":"As described in the commit (\"arm64: kexec: allocate memory space avoiding\nreserved regions\"), /proc/iomem now has a lot of \"reserved\" entries, and\nit's not just enough to have a fixed size of memory range array.\n\nWith this patch, kdump is allowed to handle arbitrary number of memory\nranges, using mem_regions_alloc_and_xxx() functions.\n\nSigned-off-by: AKASHI Takahiro \u0026lt;takahiro.akashi@linaro.org\u0026gt;\nTested-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nTested-by: Masayoshi Mizuma \u0026lt;m.mizuma@jp.fujitsu.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"AKASHI Takahiro","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}},{"oid":"f736104f533290b4ce6fbfbca74abde9ffd3888c","url":"/mbgg/kexec-tools/commit/f736104f533290b4ce6fbfbca74abde9ffd3888c","authoredDate":"2019-12-18T11:42:31.000-05:00","committedDate":"2020-01-03T09:35:47.000+01:00","shortMessage":"arm64: kexec: allocate memory space avoiding reserved regions","shortMessageMarkdown":null,"shortMessageMarkdownLink":"\u003ca data-pjax=\"true\" title=\"arm64: kexec: allocate memory space avoiding reserved regions\n\nOn UEFI/ACPI-only system, some memory regions, including but not limited\nto UEFI memory map and ACPI tables, must be preserved across kexec\u0026#39;ing.\nOtherwise, they can be corrupted and result in early failure in booting\na new kernel.\n\nIn recent kernels, /proc/iomem now has an extended file format like:\n\n 40000000-5871ffff : System RAM\n 41800000-426affff : Kernel code\n 426b0000-42aaffff : reserved\n 42ab0000-42c64fff : Kernel data\n 54400000-583fffff : Crash kernel\n 58590000-585effff : reserved\n 58700000-5871ffff : reserved\n 58720000-58b5ffff : reserved\n 58b60000-5be3ffff : System RAM\n 58b61000-58b61fff : reserved\n\nwhere the \u0026quot;reserved\u0026quot; entries at the top level or under System RAM (and\nits descendant resources) are ones of such kind and should not be regarded\nas usable memory ranges where several free spaces for loading kexec data\nwill be allocated.\n\nWith this patch, get_memory_ranges() will handle this format of file\ncorrectly. Note that, for safety, unknown regions, in addition to\n\u0026quot;reserved\u0026quot; ones, will also be excluded.\n\nSigned-off-by: AKASHI Takahiro \u0026lt;takahiro.akashi@linaro.org\u0026gt;\nTested-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nTested-by: Masayoshi Mizuma \u0026lt;m.mizuma@jp.fujitsu.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;\" class=\"color-fg-default\" href=\"/mbgg/kexec-tools/commit/f736104f533290b4ce6fbfbca74abde9ffd3888c\"\u003earm64: kexec: allocate memory space avoiding reserved regions\u003c/a\u003e","bodyMessageHtml":"On UEFI/ACPI-only system, some memory regions, including but not limited\nto UEFI memory map and ACPI tables, must be preserved across kexec'ing.\nOtherwise, they can be corrupted and result in early failure in booting\na new kernel.\n\nIn recent kernels, /proc/iomem now has an extended file format like:\n\n 40000000-5871ffff : System RAM\n 41800000-426affff : Kernel code\n 426b0000-42aaffff : reserved\n 42ab0000-42c64fff : Kernel data\n 54400000-583fffff : Crash kernel\n 58590000-585effff : reserved\n 58700000-5871ffff : reserved\n 58720000-58b5ffff : reserved\n 58b60000-5be3ffff : System RAM\n 58b61000-58b61fff : reserved\n\nwhere the \"reserved\" entries at the top level or under System RAM (and\nits descendant resources) are ones of such kind and should not be regarded\nas usable memory ranges where several free spaces for loading kexec data\nwill be allocated.\n\nWith this patch, get_memory_ranges() will handle this format of file\ncorrectly. Note that, for safety, unknown regions, in addition to\n\"reserved\" ones, will also be excluded.\n\nSigned-off-by: AKASHI Takahiro \u0026lt;takahiro.akashi@linaro.org\u0026gt;\nTested-by: Bhupesh Sharma \u0026lt;bhsharma@redhat.com\u0026gt;\nTested-by: Masayoshi Mizuma \u0026lt;m.mizuma@jp.fujitsu.com\u0026gt;\nSigned-off-by: Simon Horman \u0026lt;horms@verge.net.au\u0026gt;","authors":[{"login":null,"displayName":"AKASHI Takahiro","avatarUrl":"https://github.githubassets.com/images/gravatars/gravatar-user-420.png","isGitHub":false}],"committerAttribution":true,"committer":{"login":"horms","displayName":"Simon Horman","avatarUrl":"https://avatars.githubusercontent.com/u/65151?v=4","path":"/horms","isGitHub":false}}]}],"currentCommit":{"oid":"d4eaff6b84292ca0231505c4aba8cc6b55df79e3"},"filters":{"since":null,"until":null,"author":null,"newPath":null,"originalBranch":null,"currentBlobPath":null,"pagination":{"startCursor":"d4eaff6b84292ca0231505c4aba8cc6b55df79e3 0","endCursor":"d4eaff6b84292ca0231505c4aba8cc6b55df79e3 34","hasNextPage":true,"hasPreviousPage":false}},"metadata":{"browsingRenameHistory":null,"showProfileHelp":false,"deferredDataUrl":"/mbgg/kexec-tools/commits/deferred_commit_data/master?original_branch=master","deferredContributorUrl":"/mbgg/kexec-tools/commits/deferred_commit_contributors","softNavToCommit":true},"repo":{"id":150884530,"defaultBranch":"master","name":"kexec-tools","ownerLogin":"mbgg","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-09-29T16:51:20.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/259494?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"master","listCacheKey":"v0:1600336576.0","refType":"branch","currentOid":"d4eaff6b84292ca0231505c4aba8cc6b55df79e3"},"timedOutMessage":""},"title":"Commits · mbgg/kexec-tools","appPayload":{"helpUrl":"https://docs.github.com","enabled_features":{"commits_ux_refresh_compare":false}}}