8000 Support ECDSA and Curve25519 for https://www.mtgjson.com/ · Issue #1064 · metaeducation/ren-c · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Support ECDSA and Curve25519 for https://www.mtgjson.com/ #1064
Open
@hostilefork

Description

@hostilefork

@kealist was trying to read https://www.mtgjson.com/files/AllCards.json and it did not support any of the cipher suites we use. Their TLS 1.2 options all use Curve25519, so I went ahead and added support for picking curves since that wasn't too difficult.

But besides all using "x25519", there's another difference...that all of them use ECDSA instead of RSA. This is a bit less obvious how to implement.

More generally--the TLS code needs a revisiting now that there is more of a sound set of cryptography primitives to build on.

Here are the ciphers supported by TLS 1.2 currently on mtgjson:

TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 (0xc02b)   ECDH x25519 (eq. 3072 bits RSA)   FS	128
OLD_TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 (0xcc14)   ECDH x25519 (eq. 3072 bits RSA)   FS	256P
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 (0xcca9)   ECDH x25519 (eq. 3072 bits RSA)   FS	256P
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA (0xc009)   ECDH x25519 (eq. 3072 bits RSA)   FS   WEAK	128
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256 (0xc023)   ECDH x25519 (eq. 3072 bits RSA)   FS   WEAK	128
TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 (0xc02c)   ECDH x25519 (eq. 3072 bits RSA)   FS	256
TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA (0xc00a)   ECDH x25519 (eq. 3072 bits RSA)   FS   WEAK	256
TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384 (0xc024)   ECDH x25519 (eq. 3072 bits RSA)   FS   WEAK
4403

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0