8000 [angelscript] include the addons sources · Issue #42074 · microsoft/vcpkg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[angelscript] include the addons sources #42074

New issue
< 8000 div class="px-4">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deadlocklogic opened this issue Nov 9, 2024 · 5 comments
Closed

[angelscript] include the addons sources #42074

deadlocklogic opened this issue Nov 9, 2024 · 5 comments
Assignees
@FrankXie05
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist Stale

Comments

@deadlocklogic
Copy link
deadlocklogic commented Nov 9, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Related to #32024.
Current implementation copies the feature addon files to the installed directory but doesn't include them in the build system.

Proposed solution

This is heuristically generated, and may not be correct.
Change this:

vcpkg/ports/angelscript/portfile.cmake

Lines 25 to 28 in 813a241

# Copy the addon files
if("addons" IN_LIST FEATURES)
file(INSTALL "${SOURCE_PATH}/add_on/" DESTINATION "${CURRENT_PACKAGES_DIR}/include/angelscript" FILES_MATCHING PATTERN "*.h" PATTERN "*.cpp")
endif() 

if("addons" IN_LIST FEATURES)
     file(INSTALL "${SOURCE_PATH}/add_on/" DESTINATION "${CURRENT_PACKAGES_DIR}/include/angelscript" FILES_MATCHING PATTERN "*.h" PATTERN "*.cpp")

     file(GLOB_RECURSE ADDON_SOURCES "${CURRENT_PACKAGES_DIR}/include/angelscript/*.cpp")
     list(REMOVE_ITEM ADDON_SOURCES "${CURRENT_PACKAGES_DIR}/include/angelscript/autowrapper/generator/generateheader.cpp")
     target_sources(${ANGELSCRIPT_LIBRARY_NAME} PRIVATE ${ADDON_SOURCES})
 endif()

Describe alternatives you've considered

No response

Additional context

No response
@deadlocklogic deadlocklogic added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 9, 2024
@deadlocklogic deadlocklogic changed the title [<angelscript>] <include the addons sources> [angelscript] include the addons sources Nov 9, 2024
@FrankXie05
Copy link
Contributor
FrankXie05 commented Nov 11, 2024 •
edited
Loading

@deadlocklogic IMO, this library does not have a feature in the cmake CMakeLists.txt. This feature addon is only applicable to vcpkg to meet the issue #32024 . And the feature addon is not compiled in the upstream code. Add_on only exists as a folder of tool functions.

@dg0yt
Copy link
Contributor
dg0yt commented Nov 11, 2024

@deadlocklogic Neither this issue nor #32024 explain how the extra sources are expected to be used. There is no point in changing anything if nobody can explain how the change can be verified.

@deadlocklogic
Copy link
Author

So basically the addons feature is practically useless in its current form, there is no point copying sources to the installation directory if there aren't included in the build system.
All I am suggesting is adding the sources to the CMake target in order to link them later as a dependency, otherwise link errors will occur rendering this feature unusable.
@FrankXie05 the addons folder contains modules of helpful boilerplate code, many of them are a must have.
@dg0yt:

@deadlocklogic Neither this issue nor #32024 explain how the extra sources are expected to be used. There is no point in changing anything if nobody can explain how the change can be verified.

I gave a suggestion on how these sources could be included.

@dg0yt
Copy link
Contributor
dg0yt commented Nov 11, 2024 •
edited
Loading

I gave a suggestion on how these sources could be included.

#32024 also gave a vague suggestion, and you see the result.
Your suggestion is untested code which mixes portfile script mode (if("addons" IN_LIST FEATURES)) with CMake project mode (target_sources(...)). It is bound to fail.

But my question was not for how to achieve a particular installation effect, but for what kind of effect is intented by upstream. If they don't add it to a library, how are users expected to make use of it? Which observable (testable) result is expected from the port?

@github-actions GitHub Actions
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label May 11, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankXie05 FrankXie05

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dg0yt @deadlocklogic @FrankXie05
0