8000 Hundreds of custom configuration requests may be sent on startup before the configuration provider has registered · Issue #13166 · microsoft/vscode-cpptools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Hundreds of custom configuration requests may be sent on startup before the configuration provider has registered #13166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sean-mcmanus opened this issue Jan 17, 2025 · 3 comments · Fixed by #13167
Closed

Hundreds of custom configuration requests may be sent on startup before the configuration provider has registered #13166

sean-mcmanus opened this issue Jan 17, 2025 · 3 comments · Fixed by #13167
Labels
bug Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone
1.24.0

Comments

@sean-mcmanus
Copy link
Contributor

If you have a header open on startup, it may try to request configurations for thousands of potential source files, but the configuration provider may not have registered yet and so it may not send any configuration for any of the source files, depending on the timing. It might repro more frequently on a slower machine.
@sean-mcmanus sean-mcmanus added bug Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. Language Service labels Jan 17, 2025
@heartacker
Copy link
Contributor

catch

@Colengms
Copy link
Contributor
Colengms commented Jan 17, 2025 •
edited
Loading

We could add some additional lifecycle messages to track when providers gets registered. That may get a little complicated when factoring in live modifications to cpp_properites.json configurations.

Another approach would be to have the response indicate it failed due to the configuration provider having not yet registered. The native side could use that as a clue to skip trying to request configurations for the remaining candidates.

We might also need a message (if there isn't one already) to notify the native side that the registration has occurred, so it can recycle the configs for existing TUs.

@sean-mcmanus
Copy link
Contributor Author

When this issue is hit and the TU ends up falling back to header only IntelliSense, it gets "stuck" that way until a reload window, i.e. it stops requesting for configurations after the configuration provider has registered.

@Colengms Colengms mentioned this issue Jan 18, 2025
Merged
@github-project-automation github-project-automation bot moved this to Done in cpptools Jan 18, 2025
@sean-mcmanus sean-mcmanus added this to the 1.24.0 milestone Feb 7, 2025
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 7, 2025
@sean-mcmanus sean-mcmanus changed the title Thousands of custom configuration requests may be sent on startup before the configuration provider has registered Hundreds of custom configuration requests may be sent on startup before the configuration provider has registered Feb 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
cpptools
Status: Done
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Fix issue with config requests before provider has registered microsoft/vscode-cpptools
3 participants
@heartacker @sean-mcmanus @Colengms
0