8000 Offer completion for `# syntax=docker/dockerfile:1` · Issue #4333 · microsoft/vscode-docker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Offer completion for # syntax=docker/dockerfile:1 #4333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
< 8000 /div>
Open
segevfiner opened this issue Jun 30, 2024 · 2 comments
Open

Offer completion for # syntax=docker/dockerfile:1 #4333

segevfiner opened this issue Jun 30, 2024 · 2 comments
Labels
language-server
Milestone
1.31.0

Comments

@segevfiner
Copy link

The extension currently offers completion for # syntax syntax=docker/dockerfile:experimental, it would be nice if it would also offer # syntax=docker/dockerfile:1 as that is more recommended for general usage.

See https://docs.docker.com/reference/dockerfile/#syntax
@rcjsuen
Copy link
Contributor
rcjsuen commented Jun 30, 2024

@segevfiner Could you clarify on the purpose of using docker/dockerfile:1? How is docker/dockerfile:1 different from not specifying the syntax directive at all? Does BUILDKIT_SYNTAX take precedence or does the directive take precedence?

@segevfiner
Copy link
Author
segevfiner commented Jun 30, 2024 •
edited
Loading

If you don't specify syntax, it uses some builtin frontend version, and I'm not sure what features it supports, as in, what version is it.

BUILDKIT_SYNTAX is another way to use a different syntax and I'm not sure which takes precedence, I would assume the command line.

It's documented here as well: https://docs.docker.com/build/dockerfile/frontend/

@bwateratmsft bwateratmsft added this to the 1.31.0 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language-server
Projects
None yet
Milestone
1.31.0
Development

No branches or pull requests
3 participants
@rcjsuen @segevfiner @bwateratmsft
0