8000 In files explorer, folders aren't shown first · Issue #2473 · microsoft/vscode-docker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

In files explorer, folders aren't shown first #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bwateratmsft opened this issue Nov 9, 2020 · 3 comments · Fixed by #2491
Closed

In files explorer, folders aren't shown first #2473

bwateratmsft opened this issue Nov 9, 2020 · 3 comments · Fixed by #2491
Labels
enhancement P2
Milestone
1.8.0

Comments

@bwateratmsft
Copy link
Collaborator
bwateratmsft commented Nov 9, 2020 •
edited
Loading

image

Also--I believe we can change the icons further. IMO the file one should be more like a file, and the folders IIRC we can do closed and open folders.
UPDATE: The icons we used match what VSCode uses so I'm content.
@philliphoff
Copy link
Member

Yes, it looks like a recent VS Code update has changed their folder icon to be...not show an icon at all. We were already switching between the standard "open" and "closed" folder icon based on the node expansion state.

@philliphoff
Copy link
Member

Regarding sorting, I, personally, like the "everything sorted together" look (and using the icons to differentiate between items) rather than "folders sorted, then files sorted" look but, you're right, the latter is more consistent with VS Code's file explorer. That should be easily done.

@bwateratmsft
Copy link
Collaborator Author

Yeah, I think the ideal would be to follow VSCode's file explorer, which uses the arrows for folders and that file icon for (some) of the files--so, exactly what you have. For sorting they put folders first.

@dbreshears dbreshears added this to the 1.8.1 milestone Nov 11, 2020
@dbreshears dbreshears added P2 and removed P3 labels Nov 11, 2020
@bwateratmsft bwateratmsft mentioned this issue Nov 13, 2020
Merged
@bwateratmsft bwateratmsft self-assigned this Nov 13, 2020
@bwateratmsft bwateratmsft modified the milestones: 1.8.1, 1.8.0 Nov 13, 2020
@bwateratmsft bwateratmsft removed their assignment Nov 13, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement P2
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Sort files/folders with folders first microsoft/vscode-docker
4 participants
@dbreshears @philliphoff @bwateratmsft and others
0