8000 Replace integration-cli suite with API test suite · Issue #32866 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Replace integration-cli suite with API test suite #32866
Open
@vieux

Description

@vieux

Many tests in integration-cli rely on the Docker CLI. The CLI has moved into into a new repo, and moby should not depend on docker, so the integration test suite needs to be transitioned to a new API test suite.

Testing guidelines doc: ./TESTING.md

Execution plan:

  1. Identify and remove tests that are CLI-only. Removed tests should be documented in [Testing] Tracking issue for missing tests docker/cli#201 so that we can ensure the CLI has necessary coverage. There are many tests that test both CLI and API, but once the CLI portion is removed, the API tests are duplicated, so some can be removed
  2. Identify integration tests that should be unit tests. Top candidates include:
    • tests for error conditions
    • tests for specific flags/query params
      These tests should be replaced with unit tests
  3. Convert remaining integration-cli tests to integration/
  4. Move API integration tests from integration-cli/docker_api_*_test to integration/

See #34623 for a checklist of prioritized tests

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0