Open
Description
Many tests in integration-cli
rely on the Docker CLI. The CLI has moved into into a new repo, and moby should not depend on docker, so the integration test suite needs to be transitioned to a new API test suite.
Testing guidelines doc: ./TESTING.md
Execution plan:
- Identify and remove tests that are CLI-only. Removed tests should be documented in [Testing] Tracking issue for missing tests docker/cli#201 so that we can ensure the CLI has necessary coverage. There are many tests that test both CLI and API, but once the CLI portion is removed, the API tests are duplicated, so some can be removed
- Identify integration tests that should be unit tests. Top candidates include:
- tests for error conditions
- tests for specific flags/query params
These tests should be replaced with unit tests
- Convert remaining integration-cli tests to
integration/
- Move API integration tests from
integration-cli/docker_api_*_test
tointegration/
See #34623 for a checklist of prioritized tests