You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I thought this was limited in terms of tests to the test 262 suite test runner, but while trying to tidy some parts of object initialisation I found it's also an issue with anything using the org.mozilla.javascript.testutils.Utils methods, and likely with other things as well. I'd suggest we take a two pronged attack to this:
If the scoped passed in is null then we should create a new TopLevel rather than a NativeObject. This would make the simple path do the right thing.
We cannot simply enforce that TopLevel is passed in as some users need to pass in custom scope objects which may have a different inheritance chain, but maybe we could refactor things to require these scopes to implement a Realm interface with the only requirement being that we can store the object that should represent that.
The text was updated successfully, but these errors were encountered:
I thought this was limited in terms of tests to the test 262 suite test runner, but while trying to tidy some parts of object initialisation I found it's also an issue with anything using the
org.mozilla.javascript.testutils.Utils
methods, and likely with other things as well. I'd suggest we take a two pronged attack to this:TopLevel
rather than aNativeObject
. This would make the simple path do the right thing.TopLevel
is passed in as some users need to pass in custom scope objects which may have a different inheritance chain, but maybe we could refactor things to require these scopes to implement aRealm
interface with the only requirement being that we can store the object that should represent that.The text was updated successfully, but these errors were encountered: