8000 samba subtitles and crashing (thread-unsafe libsmbclient used across threads -> crash) · Issue #5936 · mpv-player/mpv · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
samba subtitles and crashing (thread-unsafe libsmbclient used across threads -> crash) #5936
Closed
@orbisvicis

Description

@orbisvicis

mpv version

$ ./mpv --version
mpv 0.28.0-618-gcd893626cb Copyright © 2000-2018 mpv/MPlayer/mplayer2 projects
 built on Sun Jun 17 11:06:33 EDT 2018
ffmpeg library versions:
   libavutil       56.18.102
   libavcodec      58.20.102
   libavformat     58.17.100
   libswscale      5.2.100
   libavfilter     7.25.100
   libswresample   3.2.100
ffmpeg version: N-91314-gbd47cca6a7

platform

$ cat /etc/fedora-release 
Fedora release 27 (Twenty Seven)

Reproduction steps

mpv "smb://...mkv" --sub-file "smb://...srt"

Expected behavior

Load subtitles.

Actual behavior

[smb] Could not open from LAN: 'smb://...srt'
Failed to open smb://...srt.
Can not open external file smb://...srt.

Even worse...

After I enable smb debugging, mpv now usually crashes when attempting to load the subtitles, even if run without any debugging. For example:

$ ./mpv --no-config --msg-level=smb=debug "smb://...mkv" --sub-file "smb://...srt"
Playing: smb://...mkv
[smb] Opening smb://...mkv
Using netbios name <NAME>
Using workgroup WORKGROUP.
SPNEGO(ntlmssp) login failed: NT_STATUS_WRONG_CREDENTIAL_HANDLE
[smb] Stream opened successfully.
[smb] Opening smb://...srt
Freed frame ../source3/libsmb/clireadwrite.c:667, expected ../source3/libsmb/clientgen.c:553.
talloc: access after free error - first free may be at ../libcli/smb/smb2cli_read.c:108
Bad talloc magic value - access after free
Aborted (core dumped)

Notice how the video file stream is successfully opened (anonymously), but not the subtitles. The same crash also happens with the repository-provided mpv:

$ mpv --version
mpv 0.27.2 (C) 2000-2017 mpv/MPlayer/mplayer2 projects
 built on UNKNOWN
ffmpeg library versions:
   libavutil       55.58.100
   libavcodec      57.89.100
   libavformat     57.71.100
   libswscale      4.6.100
   libavfilter     6.82.100
   libswresample   2.7.100
ffmpeg version: 3.3.7

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0