8000 Default OAuth redirect URI's break with Google's new validation URLs that require https · Issue #273 · nytimes/library · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Default OAuth redirect URI's break with Google's new validation URLs that require https #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ChrisC opened this issue Jun 9, 2021 · 1 comment
Open

Default OAuth redirect URI's break with Google's new validation URLs that require https #273

ChrisC opened this issue Jun 9, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ChrisC
Copy link
ChrisC commented Jun 9, 2021

Problem Description

The default redirect URI in the userAuth module uses http by default. Google is now enforcing https when creating Redirect URI for OAuth Clients, so the app will throw errors when trying to authorize users if you update the OAuth client config or create a new one in GCloud.

Feature

Maybe do away with the default callback url and require users to explicitly set the REDIRECT_URL in the .env file? It's not well documented in the README that you can already override the default callback URI.

Additional Information

See Google's updated OAuth requirement and validation rules.
@ChrisC ChrisC added the enhancement New feature or request label Jun 9, 2021
@jpmckinney
Copy link
Contributor

Setting REDIRECT_URL did the trick in the meantime. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpmckinney @ChrisC
0