8000 Build fails on node 20 (node-sass version in package-lock.json stops working after node 18) · Issue #362 · nytimes/library · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Build fails on node 20 (node-sass version in package-lock.json stops working after node 18) #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jpmckinney opened this issue May 8, 2023 · 5 comments
Open

Build fails on node 20 (node-sass version in package-lock.json stops working after node 18) #362

jpmckinney opened this issue May 8, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@jpmckinney
Copy link
Contributor
jpmckinney commented May 8, 2023 •
edited
Loading

Context (Environment)

All in issue title.

Expected Behavior

Build succeeds on node 20.

Actual Behavior

Build fails on node 20.

To Reproduce

npm run build:main && npm run build:inline on node 20.

Additional Information

N/A

Possible Solution

Not sure - maybe have branches/releases for node20 and node18, since they require different package-lock.json.

My current workaround is just to lock the engine to 18 in both package files (smallest edit).
@jpmckinney jpmckinney added the bug Something isn't working label May 8, 2023
@afischer
Copy link
Member
afischer commented May 8, 2023

Hi @jpmckinney, thanks for the issue. We currently we officially support 14.x, 16.x, 18.x, but will definitely look into getting node 20 working now that it's LTS!

@Morred
Copy link
Morred 8000 commented Jun 21, 2023 •
edited
Loading

I'm actually experiencing this on node 16 as well, even though it's officially supported. The only way I was able to fix it was to completely replace node-sass (which is deprecated anyways) with dart-sass. I can make a PR if that helps.

@benwerd
Copy link
benwerd commented Apr 22, 2025

Hi! Any advance on this? I'm still having issues beyond Node 18.

@afischer
Copy link
Member

Hi — I haven't had much time to look into our Node compatibility, but this is definitely something we will need to look into as Node 18 enters the the end of its maintenance period.

@benwerd
Copy link
benwerd commented Apr 30, 2025

@afischer Great - we're interested in helping at ProPublica.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpmckinney @benwerd @Morred @afischer
0