8000 annex: enable during installation · Issue #29 · neuropoly/gitea · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
annex: enable during installation #29
Open
@kousu

Description

@kousu

https://docs.gitea.io/en-us/git-lfs-setup/ says Git LFS is disabled by default

[server]
; Enables git-lfs support. true or false, default is false.
LFS_START_SERVER = true

however, in practice, it's usually turned on, because the install page fills in this text field

Screenshot 2022-11-29 at 21-04-57 Gitea Git with a cup of tea

tracing

The reason this is filled in by default is because it's initialized from [lfs.PATH]

https://github.com/neuropoly/gitea/blob/fa43bce541507c8a702723f84764a48db9278506/routers/install/install.go#L122

and that is non-nil; according to https://docs.gitea.io/en-us/config-cheat-sheet/#lfs-lfs we have these defaults:

[lfs]
STORAGE_TYPE = local
PATH = ./data/lfs  # if STORAGE_TYPE == local

and then on submit, it's read back in by

https://github.com/neuropoly/gitea/blob/fa43bce541507c8a702723f84764a48db9278506/routers/install/install.go#L416-L418

which in turn turns on LFS_START_SERVER.

Anyway, this is an annoying inconsistency between LFS and annex, so add a checkbox to the install UI for git-annex, and leave it on by default to match the LFS behaviour.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0