10000 Variation graph mapping · Issue #1132 · nf-core/eager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Variation graph mapping #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattiassherman opened this issue Apr 14, 2025 · 3 comments
Open

Variation graph mapping #1132

mattiassherman opened this issue Apr 14, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@mattiassherman
Copy link

Hi,

I was wondering if there were any plans to implement any graph mapping options in the eager pipeline?

I am currently using eager with bwa aln to map fairly divergent non-human genomes but this suffers from reference bias. I know this can be partly mitigated with relaxed mapping parameters or by lowering mapping quality, but I would like to preserve a high mapping quality.

I am planning on using vg with a list of variants (as demonstrated in https://link.springer.com/article/10.1186/s13059-020-02160-7). In the absence of an implementation in eager, I will have to stop my eager pipeline prior to the mapping step and use the output fastq to run an adjacent script with vg, and use the BAM output to carry out the later steps of the eager pipeline.

Eager has been the standard pre-processing method in my lab for years but difficulties in changing pipeline versions has made changing key steps like these challenging to implement. I think adding this to eager would benefit a lot of people, especially those working on non-human organisms who don't always have good (or closely related) reference genomes.

I hope you'll consider this improvement!

Many thanks,
Mattias

@mattiassherman mattiassherman added the enhancement New feature or request label Apr 14, 2025
@jfy133
Copy link
Member
jfy133 commented Apr 16, 2025

Hi @mattiassherman !

I think it would be a great idea!

The only problem is that I don't know if any of the dev team any experience in variation graph tools (barring @aidaanva maybe?)

We would need someone with more expertise (you maybe?) who can help us check firstly it fits within the existing framework, and then implementing it. Also because none of the dev team really work on it currently, it maybe would not be highest priority (we need to get this major rewrite out first which is still a couple of months away)

Do you think you would be able to do that or know someone who could assist?

@mattiassherman
Copy link
Author

Hi @jfy133 ,

I would happily contribute but unfortunately I don't think I quite have the expertise yet with either variation graph mapping or nextflow pipelines, although I will keep it in my mind for further along in my PhD! Perhaps once I have implemented vg as I described above, as I will have had more experience in both of those areas (and will hopefully be aware of any potential issues!).

Thank you for your response though! I really appreciate all the work the eager team puts in to standardise these pipelines!

Thanks,
Mattias

@jfy133
Copy link
Member
jfy133 commented Apr 28, 2025

OK, maybe then re-visit this issue in a couple of months once we've released eager v3, and you've progressed a bit further :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
0