8000 Addition of a parameter for the minimum depth to call a base · Issue #447 · nf-core/viralrecon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Addition of a parameter for the minimum depth to call a base #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjjossart opened this issue Nov 19, 2024 · 0 comments
Open

Addition of a parameter for the minimum depth to call a base #447

cjjossart opened this issue Nov 19, 2024 · 0 comments
Assignees
Labels
enhancement Improvement for existing functionality good first issue Good for newcomers
Milestone

Comments

@cjjossart
Copy link
8000 cjjossart commented Nov 19, 2024

Description of feature

Hello Viralrecon team,

I am requesting an addition of a parameter that would allow the user to supply a minimum depth to cal a base and thus variants as well. Currently this can be done by supplying a custom config with specific processes and update args to increase or lower the minimum depth. The variant calling and consensus modules would use this parameter. It would be ideal to have this as a parameter that can be set by a custom config or on the command line. I think the default of 10 works well, which is what these values are set in the config files. This would enhance the usability of this pipeline. Additionally, if possible it would ideal to have the metric table have a column for the genome fraction of the sample at the specified depth. For example, there is a column "% Coverage > 10x" that could possible be altered to reflect the minimum depth parameter being specified (i.e. '% Coverage > ${params.min_depth}x').

I wonder if the added parameter could be added and then placed in the config files, as to not alter or change the modules' code base. Please reach out with any questions or if I can provide further explanation. Thanks! -CJ

@cjjossart cjjossart added the enhancement Improvement for existing functionality label Nov 19, 2024
@Joon-Klaps Joon-Klaps added the good first issue Good for newcomers label Dec 16, 2024
@saramonzon saramonzon added this to the 2.7 milestone Mar 14, 2025
@gorbruno gorbruno self-assigned this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality good first issue Good for newcomers
Projects
Status: To do
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants
0