8000 Compilation failure for Angular 8 projects using v12.1 · Issue #1168 · ngx-translate/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content 8000
Compilation failure for Angular 8 projects using v12.1 #1168
Closed
lingounet/testage
#10
@Wisdomb33r

Description

@Wisdomb33r

Current behavior

Compilation error for Angular 8 projects using v12.1 of ngx-translate :

ERROR in ../node_modules/@ngx-translate/core/lib/translate.directive.d.ts:14:9 - error TS1086: An accessor cannot be declared in an ambient context.

14     set translate(key: string);

Only the first error was copy/pasted, there is a dozen of similar.

Expected behavior

TypeScript compilation should not fail as v12.1 branch is advertised for Angular 8 in the documentation.

How do you think that we should fix this?

v12.1 Angular peer dependency is set to >= 8.0.0, but TypeScript version used to compile this version of the library is 3.7.x. This is a mismatch with Angular supported TypeScript version, which are 3.4 for Angular 8.0/8.1 branches, 3.5 for Angular 8.2 branches, and 3.6/3.7 for Angular 9.

The peer dependency of v12.1 should reflect this if possible. The compatibility table of the documentation should at least be updated accordingly (currently, it still states all 12.x branches is compatible with Angular 8).

Minimal reproduction of the problem with instructions

Any Angular project with TypeScript 3.5 (which roughly means 8.2 version of Angular) cannot compile v12.1 published version.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0