-
Notifications
You must be signed in to change notification settings - Fork 30
Setting multiple secrets with cli command can trigger too many deployments #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
quick question, you mention you do it in bulk, are you managing ALL of your secrets at once or only a subset? I am mostly wondering if we should add a |
In practice, we do usually replace all our secrets at once, but I think updateManySecrets might be better and also safer because that way you'd be able to update subsets if needed without accidentally deleting other secrets. We're less in need of a bulk way to delete old secrets because it's not a common task, and it's not that hard to go clean up unused secrets manually. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
After the cli added a set secret command, we've been using it to update secrets using scripts. However, since the command triggers a deploy each time a secret is set, if you update many secrets in a row the deployments can trigger ten or even hundreds of times depending on how many secrets you have to update. Based on discord discussion, options could be to add some type of bulk update command or flag, or to wait and dedupe the deployments.
The text was updated successfully, but these errors were encountered: