8000 Internal doc link breaks navigation · Issue #1175 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Internal doc link breaks navigation #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mylogon341 opened this issue Feb 12, 2020 · 13 comments · Fixed by #1176
Closed

Internal doc link breaks navigation #1175

mylogon341 opened this issue Feb 12, 2020 · 13 comments · Fixed by #1176
Labels
bug

Comments

@mylogon341
Copy link

Inserting a link to a neighbouring document causes the navigation to stop working properly.

Environment:
Chrome browser. macOS
Self-hosted solution on aws

Reproduction steps:

  1. Create several nested documents.
  2. Create a link to a neighbouring nested document
  3. Click the link.

What should happen:
You should be able to see the content of the article and should be able to navigate correctly afterwards.

What does happen:
The article is blank. Navigation stops working correctly.

Work around:
Refresh browser to restore functionality.
@mylogon341
Copy link
Author

Video showing this in action
https://drive.google.com/file/d/1oLCXYNE5odrvu2ygCdOArluCVQqq4FIJ/view?usp=sharing
Thanks

@tommoor tommoor added the bug label Feb 12, 2020
@tommoor
Copy link
Member
tommoor commented Feb 13, 2020 •
edited
Loading

Is the link a relative link created by searching in the link editor or is it an absolute link with http etc? I'm having trouble reproducing currently
8000

@tommoor tommoor added the self-hosted Issues related to self-hosting the code label Feb 13, 2020
@tommoor tommoor changed the title Bug: Internal doc link breaks navigation Internal doc link breaks navigation Feb 13, 2020
@mylogon341
Copy link
Author

Ah, it was absolute. I wasn't aware of a relative link feature.
I just tried editing the link to a reference link and it's gone haywire too, unfortunately.
New vid
https://drive.google.com/file/d/1gGVKVgK9T5chhgWaFRcDerNvWe3Qz2E7/view?usp=sharing

@tommoor
Copy link
Member
tommoor commented Feb 13, 2020

It's frustrating that I'm unable to create the same situation as this is clearly a bug that needs fixing immediately. Are there any errors in the console?

@mylogon341
Copy link
Author
mylogon341 commented Feb 13, 2020 •
edited
Loading

sorry nope. nothing related anyway. there is one

Refused to load the font '' because it violates the following Content Security Policy directive: "default-src 'self'". Note that 'font-src' was not explicitly set, so 'default-src' is used as a fallback.

But I don't think that's related.

Happy to do a screen share if you want to debug remotely to see if anything stands out to you.

@tommoor tommoor mentioned this issue Feb 13, 2020
Merged
@tommoor
Copy link
Member
tommoor commented Feb 13, 2020

If you're in a position to try running code from a branch I believe this will resolve the issue:
#1176

@mylogon341
Copy link
Author

Excellent - I'll share it with our sys ops guys and see if they can do some git magic to try it out. It will probably mid next week before I get back to you though, unfortunately.
I'll keep you updated 👍

@mylogon341
Copy link
Author

A hah. So, that fix didnt actually fix the issue. However, i was able to kind of narrow down how to recreate it for you. Basically, if i rename the documents, the linking starts working and i am able to navigate between them freely, but as soon as I put their names back, it breaks again!

So, hopefully this will help you to recreate

Engineering is a collection btw
Engineering > Mobile > iOS > Guides > Integrating fastlane screenshots
and
Engineering > Mobile > iOS > Guides > Integrating fastlane frameit
however, if i name the documents "meh" and "blah" they and navigate totally fine.
I dont know if its a path length issue or... what ... but its definitely a bit of a strange one .
Hopefully this helps.

@tommoor
Copy link
Member
tommoor commented Feb 19, 2020

Thanks for that, I've discovered the error with these reproduction steps 👍

@tommoor tommoor reopened this Feb 19, 2020
@tommoor tommoor removed the self-hosted Issues related to self-hosting the code label Feb 19, 2020
@mylogon341
Copy link
Author

Hi tom. Sorry to be a pain, but we've pulled these changes in and it's still an issue 😢 Do you think there is some sort of 'lingering' but that means we just need to recreate the documents etc to pick up the new changes?
thanks

@tommoor
Copy link
Member
tommoor commented Feb 19, 2020

You don't need to recreate the documents. I identified the error and it was in the routing logic, I was able to reproduce and fix – the fix is also live on getoutline.com already.

I'd double check your deployment succeeded and you're running the latest javascript bundle – hard refresh?

@tommoor tommoor reopened this Feb 19, 2020
@JoeAlamo
Copy link

I can confirm this fixed the issue - the changes weren't getting picked up because our docker-compose file was using a pinned outlinewiki/outline image version 😅. Changed it so it builds it based off the Dockerfile and it is working now after a fresh deploy

@tommoor
Copy link
Member
tommoor commented Feb 23, 2020

Great, closing as resolved.

@tommoor tommoor closed this as completed Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use alternative redirect method outline/outline
3 participants
@tommoor @mylogon341 @JoeAlamo
0