8000 Move components from `reakit` to `radix-ui` · Issue #6456 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move components from reakit to radix-ui #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 of 9 tasks
tommoor opened this issue Jan 31, 2024 · 4 comments
Open
3 of 9 tasks

Move components from reakit to radix-ui #6456

tommoor opened this issue Jan 31, 2024 · 4 comments
Assignees
@apoorv-mishra
Labels
techdebt

Comments

@tommoor
Copy link
Member
tommoor commented Jan 31, 2024 •
edited
Loading

Reakit is dead, Radix won.

Sometimes we bet on the wrong frameworks and that's definitely what happened here – shadcn provides some great boilerplate to make moving across easier, combining the parts of Radix into usable UI components. We should move Outline's components one by one to radix, in particular:

  • InputSelect
  • VisuallyHidden
  • Tooltip
  • Input
  • Button
  • ArrowKeyNavigation
  • Modal
  • Popover
  • ContextMenu

The context menu will be a relatively large undertaking and as such, should be left until last.
@linear Linear
Copy link
linear bot commented Jan 31, 2024

OLN-222 Move components from `reakit` to `radix-ui`

@tommoor tommoor mentioned this issue Feb 1, 2024
Closed
@tommoor tommoor mentioned this issue Feb 12, 2024
Closed
@apoorv-mishra apoorv-mishra mentioned this issue May 24, 2024
Closed
@apoorv-mishra apoorv-mishra self-assigned this May 28, 2024
This was referenced Jun 3, 2024
Closed
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Oct 1, 2024

Automatically closed due to inactivity

@github-actions github-actions bot closed this as completed Oct 1, 2024
@hmacr hmacr mentioned this issue Feb 23, 2025
Merged
@tommoor
Copy link
Member Author
tommoor commented Mar 16, 2025 •
edited by hmacr
Loading

InputSelect

Component Migrated?
DefaultCollectionInputSelect ✅ First component that was migrated (#8541).
Details (Settings)(ToC preference) ✅ Migrated since it renders right next to DefaultCollectionInputSelect (#8541).
CommentSortMenu ✅ Migrated to test "separator" variant in select options (#8541).
Preferences (Settings)(Language and theme preferences) ✅ Migrated in #8711.
Security (Settings)(Default role for new users) ✅ Migrated in #8711.
InputMemberPermissionSelect ❌ Renders in reakit popover - best to migrate post popover component migration.
InputSelectPermission ❌ Renders in reakit popover & dialog - best to migrate post popover and dialog components migration.
SelectLocation (TemplatizeDialog) ❌ Renders in reakit dialog - best to migrate post dialog component migration.
ApiKeyNew ❌ Renders in reakit dialog - best to migrate post dialog component migration.
Invite ❌ Renders in reakit dialog - best to migrate post dialog component migration.

@tommoor tommoor reopened this Mar 16, 2025
@github-actions github-actions bot removed the stale label Mar 16, 2025
@hmacr hmacr mentioned this issue Mar 17, 2025
Merged
This was referenced May 25, 2025
Open
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apoorv-mishra apoorv-mishra

Labels
techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tommoor @apoorv-mishra
0